Add env SegmentedReduce (non fixed-size overloads)#7795
Merged
gonidelis merged 18 commits intoNVIDIA:mainfrom Mar 25, 2026
Merged
Add env SegmentedReduce (non fixed-size overloads)#7795gonidelis merged 18 commits intoNVIDIA:mainfrom
gonidelis merged 18 commits intoNVIDIA:mainfrom
Conversation
Contributor
gonidelis
force-pushed
the
segmented_redude_env
branch
from
2aa7447 to
d442948
Compare
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
gonidelis
force-pushed
the
segmented_redude_env
branch
from
83c6791 to
535da7d
Compare
This comment has been minimized.
This comment has been minimized.
gonidelis
force-pushed
the
segmented_redude_env
branch
from
535da7d to
7a15fdf
Compare
Member
Author
|
I removed the helper underlying implementation function for fixed segment size overloads as it pre required knowledge of the |
Member
Author
|
adding missing unit tests just now |
gonidelis
force-pushed
the
segmented_redude_env
branch
from
4d49de7 to
44d9d80
Compare
gonidelis
force-pushed
the
segmented_redude_env
branch
from
44d9d80 to
f4048ec
Compare
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Mar 10, 2026
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Looks good.
@bernhardmgruber I observe that we are really loose with the naming conventions We have InitValueT, init_value_t, init_t, no alias at all Same for AccumT and so on
We really should be more consistent
Member
Author
gonidelis
force-pushed
the
segmented_redude_env
branch
from
f4048ec to
e62f191
Compare
This comment has been minimized.
This comment has been minimized.
pauleonix
reviewed
Mar 20, 2026
…r to common impl
- Add private segmented_reduce_impl that centralizes determinism
validation (static_assert rejecting gpu_to_gpu), dispatch_with_env,
and tuning extraction, eliminating boilerplate across all env overloads
- Refactor Reduce, Sum, Min, Max env overloads to delegate to
segmented_reduce_impl
- Add new env overloads for ArgMin and ArgMax with full documentation
including literalinclude snippet tags
- Rewrite env_api tests covering all 6 APIs (Reduce, Sum, Min, Max,
ArgMin, ArgMax) with determinism and stream_ref acceptance tests
- Unify _env.cu and _env_launch.cu into a single _env.cu test file
with default env, launch wrapper, custom stream, and tuning tests
…ed extra redundant logic for no reason
- Add missing non-overlap precondition to env ArgMin and ArgMax docs - Reorder env tests: group all env tests before custom stream tests - Add not_guaranteed determinism test for Reduce env API
gonidelis
force-pushed
the
segmented_redude_env
branch
from
3e66fa1 to
20a1056
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
The header looks fine, except one issue:
gonidelis
force-pushed
the
segmented_redude_env
branch
from
20a1056 to
81312a6
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 10m: Pass: 100%/249 | Total: 2d 15h | Max: 53m 29s | Hits: 97%/159713See results here. |
bernhardmgruber
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split (1/2)
Adds env based overloads for non fixed-size segments
DeviceSegmentedReduce::*algorithmsMerge before #8097
Segmented Reduce is inherently
run_to_rundeterministic thus this is the largest deterministic guarantee allowed. If you believe there at some point can be an a perf optimization that will ruin this contract let me know and we will remove this promise in this PR. Otherwise we stay bound to that.