Skip to content

Unified equal_to_value functions #8114

Merged
davebayer merged 6 commits intoNVIDIA:mainfrom
dhruvilmehta:equal_to
Mar 20, 2026
Merged

Unified equal_to_value functions #8114
davebayer merged 6 commits intoNVIDIA:mainfrom
dhruvilmehta:equal_to

Conversation

@dhruvilmehta
Copy link
Contributor

@dhruvilmehta dhruvilmehta commented Mar 19, 2026

Description

closes #7457

Removed all the equal_to_val implementations and used equal_to_value from cuda::_functional::equal_to_value.h

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dhruvilmehta dhruvilmehta requested a review from a team as a code owner March 19, 2026 20:39
@github-project-automation github-project-automation bot moved this to Todo in CCCL Mar 19, 2026
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Mar 19, 2026
@oleksandr-pavlyk oleksandr-pavlyk added the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
@oleksandr-pavlyk oleksandr-pavlyk added the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
Co-authored-by: Oleksandr Pavlyk <21087696+oleksandr-pavlyk@users.noreply.github.com>
@oleksandr-pavlyk oleksandr-pavlyk added the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix apply pre-commit auto-fixes automatically label Mar 19, 2026
@oleksandr-pavlyk
Copy link
Contributor

/ok to test c2c21b2

@github-actions

This comment has been minimized.

Copy link
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the PR! However, I don't think this is a functionality we would like to publicly expose, nor maintain. Maybe @miscco will have different opinion

@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Mar 20, 2026
@miscco
Copy link
Contributor

miscco commented Mar 20, 2026

We decided that the functor is trivial enough to be public

Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
@miscco
Copy link
Contributor

miscco commented Mar 20, 2026

pre-commit.ci autofix

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Mar 20, 2026
@bernhardmgruber
Copy link
Contributor

/ok to test b51dccd

@davebayer
Copy link
Contributor

We decided that the functor is trivial enough to be public

Oh, I somehow missed that

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 53m 43s: Pass: 100%/118 | Total: 1d 05h | Max: 42m 43s | Hits: 99%/360788

See results here.

@davebayer davebayer merged commit e1329ca into NVIDIA:main Mar 20, 2026
137 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEA]: Unify equal_to_value

5 participants