Skip to content

Commit 450819d

Browse files
committed
Changes for style guide compliance
Signed-off-by: Andrew Chen <[email protected]>
1 parent 20781df commit 450819d

File tree

7 files changed

+18
-19
lines changed

7 files changed

+18
-19
lines changed

container-toolkit/arch-overview.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ This component is included in the `nvidia-container-toolkit` package.
7878

7979
This component includes an executable that implements the interface required by a `runC` `prestart` hook. This script is invoked by `runC`
8080
after a container has been created, but before it has been started, and is given access to the `config.json` associated with the container
81-
(e.g. this [config.json](https://github.com/opencontainers/runtime-spec/blob/master/config.md#configuration-schema-example=) ). It then takes
81+
(such as this [config.json](https://github.com/opencontainers/runtime-spec/blob/master/config.md#configuration-schema-example=) ). It then takes
8282
information contained in the `config.json` and uses it to invoke the `nvidia-container-cli` CLI with an appropriate set of flags. One of the
8383
most important flags being which specific GPU devices should be injected into the container.
8484

@@ -111,7 +111,7 @@ To use Kubernetes with Docker, you need to configure the Docker `daemon.json` to
111111
a reference to the NVIDIA Container Runtime and set this runtime as the default. The NVIDIA Container Toolkit contains a utility to update this file
112112
as highlighted in the `docker`-specific installation instructions.
113113

114-
See the {doc}`install-guide` for more information on installing the NVIDIA Container Toolkit on various Linux distributions.
114+
Refer to the {doc}`install-guide` for more information on installing the NVIDIA Container Toolkit on various Linux distributions.
115115

116116
### Package Repository
117117

@@ -130,7 +130,7 @@ For the different components:
130130

131131
:::{note}
132132
As of the release of version `1.6.0` of the NVIDIA Container Toolkit the packages for all components are
133-
published to the `libnvidia-container` `repository <https://nvidia.github.io/libnvidia-container/>` listed above. For older package versions please see the documentation archives.
133+
published to the `libnvidia-container` `repository <https://nvidia.github.io/libnvidia-container/>` listed above. For older package versions refer to the documentation archives.
134134
:::
135135

136136
Releases of the software are also hosted on `experimental` branch of the repository and are graduated to `stable` after test/validation. To get access to the latest

container-toolkit/docker-specialized.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ The supported constraints are provided below:
206206
- constraint on the compute architectures of the selected GPUs.
207207
208208
* - ``brand``
209-
- constraint on the brand of the selected GPUs (e.g. GeForce, Tesla, GRID).
209+
- constraint on the brand of the selected GPUs (such as GeForce, Tesla, GRID).
210210
```
211211
212212
Multiple constraints can be expressed in a single environment variable: space-separated constraints are ORed,

container-toolkit/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ The NVIDIA Container Toolkit is a collection of libraries and utilities enabling
3535
## License
3636

3737
The NVIDIA Container Toolkit (and all included components) is licensed under [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0) and
38-
contributions are accepted with a Developer Certificate of Origin (DCO). See the [contributing](https://github.com/NVIDIA/nvidia-container-toolkit/blob/master/CONTRIBUTING.md) document for
38+
contributions are accepted with a Developer Certificate of Origin (DCO). Refer to the [contributing](https://github.com/NVIDIA/nvidia-container-toolkit/blob/master/CONTRIBUTING.md) document for
3939
more information.

container-toolkit/install-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Alternatively, you can install the driver by [downloading](https://www.nvidia.co
2121
```{note}
2222
There is a [known issue](troubleshooting.md#containers-losing-access-to-gpus-with-error-failed-to-initialize-nvml-unknown-error) on systems
2323
where `systemd` cgroup drivers are used that cause containers to lose access to requested GPUs when
24-
`systemctl daemon reload` is run. Please see the troubleshooting documentation for more information.
24+
`systemctl daemon reload` is run. Refer to the troubleshooting documentation for more information.
2525
```
2626

2727
(installing-with-apt)=
@@ -201,7 +201,7 @@ No additional configuration is needed.
201201
You can just run `nerdctl run --gpus=all`, with root or without root.
202202
You do not need to run the `nvidia-ctk` command mentioned above for Kubernetes.
203203

204-
See also the [nerdctl documentation](https://github.com/containerd/nerdctl/blob/main/docs/gpu.md).
204+
Refer to the [nerdctl documentation](https://github.com/containerd/nerdctl/blob/main/docs/gpu.md) for more information.
205205

206206
### Configuring CRI-O
207207

container-toolkit/release-notes.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ This release of the NVIDIA Container Toolkit `v1.17.7` is a bugfix and minor fea
103103
### Fixes and Features
104104
- Fixed mode detection on Thor-based systems. With this change, the runtime mode correctly resolves to `csv`.
105105
- Fixed the resolution of libraries in the LDCache on ARM. This fixes CDI spec generation on ARM-based systems using NVML.
106-
- Added a `nvidia-container-runtime-modes.legacy.cuda-compat-mode` option to provide finer control of how CUDA Forward Compatibility is handled. The default value (`ldconfig`) fixes CUDA Compatibility Support in cases where only the NVIDIA Container Runtime Hook is used (e.g. the Docker `--gpus` command line flag).
106+
- Added a `nvidia-container-runtime-modes.legacy.cuda-compat-mode` option to provide finer control of how CUDA Forward Compatibility is handled. The default value (`ldconfig`) fixes CUDA Compatibility Support in cases where only the NVIDIA Container Runtime Hook is used (such as the Docker `--gpus` command line flag).
107107
- Improved the `update-ldcache` hook to run in isolated namespaces. This improves hook security.
108108

109109

@@ -386,7 +386,7 @@ The following `container-toolkit` conatiners are included:
386386
- Added support for requesting IMEX channels as volume mounts.
387387
- Added a `disable-imex-channel-creation` feature flag to disable the creation of IMEX channel device nodes when creating a container.
388388
- Added IMEX channel device nodes to the CDI specifications in `management` mode.
389-
- Added the creation of select driver symlinks (e.g. `libcuda.so`) in CDI specification generation to match the behavior in the `legacy` mode.
389+
- Added the creation of select driver symlinks (such as `libcuda.so`) in CDI specification generation to match the behavior in the `legacy` mode.
390390

391391

392392
### Enhancements to container-toolkit Container Images
@@ -429,7 +429,7 @@ The following `container-toolkit` conatiners are included:
429429
### Fixes and Features
430430

431431
- Excluded `libnvidia-allocator` from graphics mounts. This fixes a bug that leaks mounts when a container is started with bi-directional mount propagation.
432-
- Used empty string for default `runtime-config-override`. This removes a redundant warning for runtimes (e.g. Docker) where this is not applicable.
432+
- Used empty string for default `runtime-config-override`. This removes a redundant warning for runtimes (such as Docker) where this is not applicable.
433433

434434
### Enhancements to container-toolkit Container Images
435435

@@ -866,7 +866,7 @@ The following `container-toolkit` containers are included:
866866

867867
### Fixes and Features
868868

869-
- Fixed a bug which would cause the update of an ldcache in the container to fail for images that do no use ldconfig (e.g. `busybox`).
869+
- Fixed a bug which would cause the update of an ldcache in the container to fail for images that do no use ldconfig (such as `busybox`).
870870
- Fixed a bug where a failure to determine the CUDA driver version would cause the container to fail to start if `NVIDIA_DRIVER_CAPABILITIES` included `graphics` or `display` on Debian systems.
871871
- Fixed CDI specification generation on Debian systems.
872872

@@ -1060,7 +1060,7 @@ Note that this release does not include an update to `nvidia-docker2` and is com
10601060
- Add `cdi` mode to NVIDIA Container Runtime
10611061
- Add discovery of GPUDirect Storage (`nvidia-fs*`) devices if the `NVIDIA_GDS` environment variable of the container is set to `enabled`
10621062
- Add discovery of MOFED Infiniband devices if the `NVIDIA_MOFED` environment variable of the container is set to `enabled`
1063-
- Add `nvidia-ctk runtime configure` command to configure the Docker config file (e.g. `/etc/docker/daemon.json`) for use with the NVIDIA Container Runtime.
1063+
- Add `nvidia-ctk runtime configure` command to configure the Docker config file (such as `/etc/docker/daemon.json`) for use with the NVIDIA Container Runtime.
10641064

10651065
#### specific to libnvidia-container
10661066

@@ -1145,7 +1145,7 @@ The following packages have also been updated to depend on `nvidia-container-too
11451145
- Bump `libtirpc` to `1.3.2`
11461146
- Fix bug when running host ldconfig using glibc compiled with a non-standard prefix
11471147
- Add `libcudadebugger.so` to list of compute libraries
1148-
- \[WSL2\] Fix segmentation fault on WSL2s system with no adpaters present (e.g. `/dev/dxg` missing)
1148+
- \[WSL2\] Fix segmentation fault on WSL2s system with no adpaters present (such as `/dev/dxg` missing)
11491149
- Ignore pending MIG mode when checking if a device is MIG enabled
11501150
- \[WSL2\] Fix bug where `/dev/dxg` is not mounted when `NVIDIA_DRIVER_CAPABILITIES` does not include "compute"
11511151

container-toolkit/supported-platforms.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,16 @@ Recent NVIDIA Container Toolkit releases are tested and expected to work on thes
2222
| Ubuntu 24.04 | X | | X |
2323

2424

25-
## Please report issues
25+
## Report issues
2626

2727
Our qualification-testing procedures are constantly evolving and we might miss
28-
certain problems. Please
29-
[report](https://github.com/NVIDIA/nvidia-container-toolkit/issues) issues in
28+
certain problems. [Report](https://github.com/NVIDIA/nvidia-container-toolkit/issues) issues in
3029
particular as they occur on a platform listed above.
3130

3231

3332
## Other Linux distributions
3433

35-
Releases may work on more platforms than indicated in the table above (e.g., on distribution versions older and newer than listed).
34+
Releases may work on more platforms than indicated in the table above (such as on distribution versions older and newer than listed).
3635
Give things a try and we invite you to [report](https://github.com/NVIDIA/nvidia-container-toolkit/issues) any issue observed even if your Linux distribution is not listed.
3736

3837
----

container-toolkit/troubleshooting.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ Review the SELinux policies on your system.
124124

125125
## Containers losing access to GPUs with error: "Failed to initialize NVML: Unknown Error"
126126

127-
When using the NVIDIA Container Runtime Hook (i.e. the Docker `--gpus` flag or
127+
When using the NVIDIA Container Runtime Hook (that is, the Docker `--gpus` flag or
128128
the NVIDIA Container Runtime in `legacy` mode) to inject requested GPUs and driver
129-
libraries into a container, the hook makes modifications, including setting up cgroup access, to the container without the low-level runtime (e.g. `runc`) being aware of these changes.
129+
libraries into a container, the hook makes modifications, including setting up cgroup access, to the container without the low-level runtime (such as `runc`) being aware of these changes.
130130
The result is that updates to the container may remove access to the requested GPUs.
131131

132132
When the container loses access to the GPU, you will see the following error message from the console output:

0 commit comments

Comments
 (0)