Skip to content

Commit 8f1ba4b

Browse files
authored
Fix HyperConverged CR edits for OpenShift Virtualization (#128)
Signed-off-by: Christopher Desiniotis <[email protected]>
1 parent 844902d commit 8f1ba4b

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

openshift/openshift-virtualization.rst

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -83,18 +83,17 @@ Prerequisites
8383

8484
* `Install the OpenShift Virtualization Operator <https://docs.openshift.com/container-platform/latest/virt/install/installing-virt-cli.html>`__.
8585
* `Install the virtctl client <https://docs.openshift.com/container-platform/latest/virt/virt-using-the-cli-tools.html>`__.
86-
* Starting with OpenShift Virtualization 4.12.3 and 4.13.0, set the ``DisableMDEVConfiguration`` feature gate:
86+
* Starting with OpenShift Virtualization 4.12.3 and 4.13.0, set the ``disableMDevConfiguration`` feature gate:
8787

8888
.. code-block:: console
8989
90-
$ oc annotate --overwrite -n openshift-cnv hco kubevirt-hyperconverged \
91-
kubevirt.kubevirt.io/jsonpatch='[{"op": "add", "path": "/spec/configuration/developerConfiguration/featureGates/-", "value": "DisableMDEVConfiguration" }]'
90+
$ kubectl patch hyperconverged -n openshift-cnv kubevirt-hyperconverged --type='json' -p='[{"op": "add", "path": "/spec/featureGates/disableMDevConfiguration", "value": true}]'
9291
9392
*Example Output*
9493

9594
.. code-block:: output
9695
97-
hyperconverged.hco.kubevirt.io/kubevirt-hyperconverged annotated
96+
hyperconverged.hco.kubevirt.io/kubevirt-hyperconverged patched
9897
9998
10099
**********************************
@@ -363,22 +362,19 @@ The following example permits the A10 GPU device and A10-24Q vGPU device.
363362
Subsystem: NVIDIA Corporation GA102GL [A10] [10de:1482]
364363
Kernel modules: nvidiafb, nouveau
365364
366-
#. Modify the ``HyperConvered`` custom resource like the following partial example:
365+
#. Modify the ``HyperConverged`` custom resource like the following partial example:
367366

368367
.. code-block:: yaml
369368
370369
...
371370
spec:
372-
configuration:
373-
developerConfiguration:
374-
featureGates:
375-
- GPU
376-
- DisableMDEVConfiguration
377-
permittedHostDevices:
378-
pciHostDevices:
379-
- externalResourceProvider: true
380-
pciDeviceSelector: 10DE:2236
381-
resourceName: nvidia.com/GA102GL_A10
371+
featureGates:
372+
disableMDevConfiguration: true
373+
permittedHostDevices:
374+
pciHostDevices:
375+
- externalResourceProvider: true
376+
pciDeviceSelector: 10DE:2236
377+
resourceName: nvidia.com/GA102GL_A10
382378
mediatedDevices:
383379
- externalResourceProvider: true
384380
mdevNameSelector: NVIDIA A10-24Q

0 commit comments

Comments
 (0)