-
Notifications
You must be signed in to change notification settings - Fork 431
Open
Labels
dependenciesIssue/PR Pull about a dependency fileIssue/PR Pull about a dependency filegood-first-issueIssues that are friendly to new contributorsIssues that are friendly to new contributors
Description
Problem
The nested tests/e2e Go module references the main github.com/NVIDIA/gpu-operator module via a relative replace directive. As a result, when Dependabot updates dependencies in the top-level module (such as k8s.io/*), the nested module can end up with stale dependencies. This is because Dependabot does not automatically apply updates to all Go modules in the repository.
Impact:
- Running
make checkfails after a Dependabot PR because it triggersgo -C tests/e2e mod tidy, resulting in uncommitted changes totests/e2e/go.modandgo.sum. - This was seen in Bump the k8sio group with 4 updates #1979 (see workflow failure). The issue had to be fixed manually in this commit.
Solution needed
- Either a Dependabot configuration that updates all modules (including
tests/e2e) when dependencies change, OR - An extra CI step that runs
go mod tidyon all modules (including nested ones) and commits any changes automatically.
Metadata
Metadata
Assignees
Labels
dependenciesIssue/PR Pull about a dependency fileIssue/PR Pull about a dependency filegood-first-issueIssues that are friendly to new contributorsIssues that are friendly to new contributors