Skip to content

Commit 68df94e

Browse files
fix(scp): log SFTP MkdirAll error instead of discarding
The error was silently discarded with '_ ='. Log it as a warning so permission-denied or disk-full errors are diagnosable. Audit finding #26 (LOW).
1 parent 86aa79d commit 68df94e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cmd/cli/scp/scp.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,9 @@ func (m command) copyFileToRemote(client *sftp.Client, localPath, remotePath str
218218

219219
// Ensure remote directory exists (use path, not filepath, for POSIX remote paths)
220220
remoteDir := path.Dir(remotePath)
221-
_ = client.MkdirAll(remoteDir) // best-effort, directory may already exist
221+
if err := client.MkdirAll(remoteDir); err != nil {
222+
m.log.Warning("Failed to create remote directory %s (may already exist): %v", remoteDir, err)
223+
}
222224

223225
// Create remote file
224226
remoteFile, err := client.Create(remotePath)

0 commit comments

Comments
 (0)