feat: parameterize environment variables in Helm chart#1624
Open
ben-gutman wants to merge 1 commit intoNVIDIA:mainfrom
Open
feat: parameterize environment variables in Helm chart#1624ben-gutman wants to merge 1 commit intoNVIDIA:mainfrom
ben-gutman wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Moves 15 hardcoded ENV variables to values.yaml for configurability: - Config-manager init container settings (NODE_LABEL, CONFIG_FILE_*, signals) - Sidecar container settings (ONESHOT, SEND_SIGNAL, process names) - Main container NVIDIA runtime settings (VISIBLE_DEVICES, DRIVER_CAPABILITIES, etc.) All default values match original hardcoded values for 100% backward compatibility. Enables users to customize paths, labels, and NVIDIA settings for diverse environments. Chart version bumped to 0.19.0 (minor) as this adds new configuration features. Signed-off-by: Ben Gutman <98455608+ben-gutman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR parameterizes 15 hardcoded environment variables across the 3 DaemonSet templates (device-plugin, gpu-feature-discovery, mps-control-daemon), moving them to `values.yaml` for greater configurability.
Motivation
The chart currently hardcodes several ENV variables that users might need to customize for different Kubernetes environments:
This change makes the chart more flexible while maintaining full backward compatibility.
Changes
Backward Compatibility
✅ 100% backward compatible - All defaults match original hardcoded values exactly.
Users upgrading from 0.18.0 will see no behavior change unless they explicitly override values.
Testing
Example Usage
Signed-off-by: Ben Gutman ben.gutman@gong.io