Skip to content

Commit 2d9e4cb

Browse files
Evan Lezarelezar
authored andcommitted
Merge branch 'set-nvidia-ctk-path' into 'main'
Set nvidia-ctk.path config option based on installed path See merge request nvidia/container-toolkit/container-toolkit!334
1 parent 12aca45 commit 2d9e4cb

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

test/container/toolkit_test.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ testing::toolkit::install() {
6161
grep -q -E "^\s*ldconfig = \"@${nvidia_run_dir}/driver/sbin/ldconfig(.real)?\"" "${shared_dir}/usr/local/nvidia/toolkit/.config/nvidia-container-runtime/config.toml"
6262
grep -q -E "^\s*root = \"${nvidia_run_dir}/driver\"" "${shared_dir}/usr/local/nvidia/toolkit/.config/nvidia-container-runtime/config.toml"
6363
grep -q -E "^\s*path = \"/usr/local/nvidia/toolkit/nvidia-container-cli\"" "${shared_dir}/usr/local/nvidia/toolkit/.config/nvidia-container-runtime/config.toml"
64+
grep -q -E "^\s*path = \"/usr/local/nvidia/toolkit/nvidia-ctk\"" "${shared_dir}/usr/local/nvidia/toolkit/.config/nvidia-container-runtime/config.toml"
6465
}
6566

6667
testing::toolkit::delete() {

tools/container/toolkit/toolkit.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,14 @@ func Install(cli *cli.Context, opts *options) error {
204204
return fmt.Errorf("error installing NVIDIA container runtime hook: %v", err)
205205
}
206206

207-
err = installToolkitConfig(toolkitConfigPath, nvidiaContainerCliExecutable, opts)
207+
nvidiaCTKPath, err := installContainerToolkitCLI(opts.toolkitRoot)
208208
if err != nil {
209-
return fmt.Errorf("error installing NVIDIA container toolkit config: %v", err)
209+
return fmt.Errorf("error installing NVIDIA Container Toolkit CLI: %v", err)
210210
}
211211

212-
_, err = installContainerToolkitCLI(opts.toolkitRoot)
212+
err = installToolkitConfig(toolkitConfigPath, nvidiaContainerCliExecutable, nvidiaCTKPath, opts)
213213
if err != nil {
214-
return fmt.Errorf("error installing NVIDIA Container Toolkit CLI: %v", err)
214+
return fmt.Errorf("error installing NVIDIA container toolkit config: %v", err)
215215
}
216216

217217
return nil
@@ -267,7 +267,7 @@ func installLibrary(libName string, toolkitRoot string) error {
267267

268268
// installToolkitConfig installs the config file for the NVIDIA container toolkit ensuring
269269
// that the settings are updated to match the desired install and nvidia driver directories.
270-
func installToolkitConfig(toolkitConfigPath string, nvidiaContainerCliExecutablePath string, opts *options) error {
270+
func installToolkitConfig(toolkitConfigPath string, nvidiaContainerCliExecutablePath string, nvidiaCTKPath string, opts *options) error {
271271
log.Infof("Installing NVIDIA container toolkit config '%v'", toolkitConfigPath)
272272

273273
config, err := toml.LoadFile(nvidiaContainerToolkitConfigSource)
@@ -316,6 +316,9 @@ func installToolkitConfig(toolkitConfigPath string, nvidiaContainerCliExecutable
316316
config.Set(key, value)
317317
}
318318

319+
// Set nvidia-ctk options
320+
config.Set("nvidia-ctk.path", nvidiaCTKPath)
321+
319322
_, err = config.WriteTo(targetConfig)
320323
if err != nil {
321324
return fmt.Errorf("error writing config: %v", err)

0 commit comments

Comments
 (0)