Skip to content

πŸ›[BUG]: dimensions in Chip 2D exampleΒ #120

@shourya-p-otta

Description

@shourya-p-otta

Version

23.09,23.11, 24.01

On which installation method(s) does this occur?

No response

Describe the issue

nd_copper_source_grad = copper_heat_flux * length_scale / temp_scale is not non-dimensional.
Looks like final units are W/m^2/m-K = kg m^2 / s^3 /m^2 /m-K = kg / s^3 /m-K. This needs to be fixed.

https://github.com/NVIDIA/modulus-sym/blob/dc5c0f759bb19e710fae0ba70cda63e129102774/examples/chip_2d/chip_2d_solid_fluid_heat_transfer_heat.py#L115

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

Metadata

Metadata

Assignees

Labels

? - Needs TriageNeed team to review and classifybugSomething isn't workingexternalIssues/PR filed by people outside the core team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions