Migrate to modern logger interface#246
Merged
saikrishnanc-nv merged 3 commits intoNVIDIA:mainfrom Jul 17, 2025
emmanuel-ferdman:main
Merged
Migrate to modern logger interface#246saikrishnanc-nv merged 3 commits intoNVIDIA:mainfrom emmanuel-ferdman:main
saikrishnanc-nv merged 3 commits intoNVIDIA:mainfrom
emmanuel-ferdman:main
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Collaborator
|
/blossom-ci |
Contributor
|
Hi @emmanuel-ferdman - Sorry about the delay in getting to this! Otherwise this looks good to me, thanks for submitting this! |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
/blossom-ci |
1 similar comment
Contributor
|
/blossom-ci |
Contributor
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
The
logger.warn()method is deprecated since Python2.7 and replaced withlogger.warning(). It leads to those warnings:This small PR resolves those warnings. It also fixes a few typos along the way.
Checklist
Dependencies