Skip to content

Adds notes on lambda weighting, clarifies Darcy PDE definition, and update theory notes#252

Merged
peterdsharpe merged 5 commits intoNVIDIA:mainfrom
peterdsharpe:psharpe/docs-update
Jul 18, 2025
Merged

Adds notes on lambda weighting, clarifies Darcy PDE definition, and update theory notes#252
peterdsharpe merged 5 commits intoNVIDIA:mainfrom
peterdsharpe:psharpe/docs-update

Conversation

@peterdsharpe
Copy link
Collaborator

@peterdsharpe peterdsharpe commented Jul 16, 2025 •
edited
Loading

PhysicsNeMo Pull Request

Addresses #128, #173, and adds other clarifications

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@peterdsharpe peterdsharpe mentioned this pull request Jul 16, 2025
Closed
@peterdsharpe peterdsharpe self-assigned this Jul 16, 2025
@peterdsharpe peterdsharpe requested a review from ktangsali July 16, 2025 17:29
@peterdsharpe
Copy link
Collaborator Author

peterdsharpe commented Jul 16, 2025

/blossom-ci

@peterdsharpe peterdsharpe changed the title Adds notes on lambda weighting and update theory notes Adds notes on lambda weighting, clarifies Darcy PDE definition, and update theory notes Jul 16, 2025
@peterdsharpe peterdsharpe mentioned this pull request Jul 16, 2025
Closed
@peterdsharpe peterdsharpe requested a review from megnvidia July 16, 2025 21:25
@peterdsharpe
Copy link
Collaborator Author

peterdsharpe commented Jul 17, 2025

/blossom-ci

ktangsali
ktangsali approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@peterdsharpe
Copy link
Collaborator Author

peterdsharpe commented Jul 18, 2025

/blossom-ci

@peterdsharpe peterdsharpe merged commit 6a3f664 into NVIDIA:main Jul 18, 2025
1 check passed
@peterdsharpe peterdsharpe deleted the psharpe/docs-update branch July 18, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktangsali ktangsali ktangsali approved these changes

@megnvidia megnvidia Awaiting requested review from megnvidia

Assignees

@peterdsharpe peterdsharpe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterdsharpe @ktangsali