Skip to content

Add LFU evict strategy to dynamicemb#52

Merged
shijieliu merged 8 commits intoNVIDIA:mainfrom
z52527:enh-dynamicemb_LFU_evict_strategy
Jun 4, 2025
Merged

Add LFU evict strategy to dynamicemb#52
shijieliu merged 8 commits intoNVIDIA:mainfrom
z52527:enh-dynamicemb_LFU_evict_strategy

Conversation

@z52527
Copy link
Collaborator

@z52527 z52527 commented May 25, 2025

Description

#10
Add LFU evict strategy to dynamicemb

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@z52527
Copy link
Collaborator Author

z52527 commented May 25, 2025

Currently it works but the test is wrong
I still have a lot of questions about score settings and test design.
@shijieliu @jiashuy Are you free to discuss this on Monday afternoon(5.26 pm 1:00~)?

@jiashuy
Copy link
Collaborator

jiashuy commented May 26, 2025

Currently it works but the test is wrong I still have a lot of questions about score settings and test design. @shijieliu @jiashuy Are you free to discuss this on Monday afternoon(5.26 pm 1:00~)?

OK for me

@z52527 z52527 force-pushed the enh-dynamicemb_LFU_evict_strategy branch from 1a354c9 to 4b3fc9b Compare May 26, 2025 09:48
@z52527 z52527 changed the title [Draft] Add LFU evict strategy to dynamicemb Add LFU evict strategy to dynamicemb Jun 3, 2025
@z52527
Copy link
Collaborator Author

z52527 commented Jun 4, 2025

CI status

Copy link
Collaborator

@jiashuy jiashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shijieliu shijieliu merged commit e48294d into NVIDIA:main Jun 4, 2025
@z52527 z52527 deleted the enh-dynamicemb_LFU_evict_strategy branch June 4, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants