chore: update go, linter, fix linter errors

Author: lockwobr

.github/workflows/agent-ci.yaml

@@ -35,6 +35,7 @@ on:
 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
+  GO_VERSION: 1.26.0
   PYTHON_VERSION: 3.13
   DEBIAN_VERSION: trixie
 jobs:
@@ -266,10 +267,10 @@ jobs:
           fetch-tags: true
           fetch-depth: 0
 
-      - name: Set up Go
+      - name: Set up Go ${{ env.GO_VERSION }}
         uses: actions/setup-go@v5
         with:
-          go-version: '1.25.6'
+          go-version: ${{ env.GO_VERSION }}
           cache-dependency-path: operator/go.sum
 
       - name: Log in to the Container registry
@@ -291,8 +292,8 @@ jobs:
         id: cached-binaries
         uses: actions/cache/restore@v4
         with:
-          key: 1.25.6-${{ runner.os }}-${{ runner.arch }}-bin-${{ hashFiles('operator/deps.mk') }}
-          restore-keys: 1.25.6-${{ runner.os }}-${{ runner.arch }}-bin-
+          key: ${{ env.GO_VERSION }}-${{ runner.os }}-${{ runner.arch }}-bin-${{ hashFiles('operator/deps.mk') }}
+          restore-keys: ${{ env.GO_VERSION }}-${{ runner.os }}-${{ runner.arch }}-bin-
           path: |
             ${{ github.workspace }}/operator/bin
             ~/.cache/go-build
@@ -307,7 +308,7 @@ jobs:
         if: steps.cached-binaries.outputs.cache-hit != 'true'
         uses: actions/cache/save@v4
         with:
-          key: 1.25.6-${{ runner.os }}-${{ runner.arch }}-bin-${{ hashFiles('operator/deps.mk') }}
+          key: ${{ env.GO_VERSION }}-${{ runner.os }}-${{ runner.arch }}-bin-${{ hashFiles('operator/deps.mk') }}
           path: |
             ${{ github.workspace }}/operator/bin
             ~/.cache/go-build

.github/workflows/cli-release.yaml

@@ -23,7 +23,7 @@ on:
       - cli/*
 
 env:
-  GO_VERSION: 1.25.6
+  GO_VERSION: 1.26.0
 
 jobs:
   release:

.github/workflows/operator-ci.yaml

@@ -41,7 +41,7 @@ on:
 env:
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository }}
-  GO_VERSION: 1.25.6
+  GO_VERSION: 1.26.0
   DEBIAN_VERSION: trixie
   PLATFORMS: linux/amd64,linux/arm64
 

operator/.golangci.yml

@@ -61,6 +61,7 @@ linters:
         path: api/*
       - linters:
           - dupl
+          - prealloc
         path: _test\.go
       - linters:
           - dupl

operator/Makefile

@@ -16,9 +16,9 @@ include deps.mk
 
 ## Version of the operator
 VERSION ?= $(GIT_TAG_LAST)
-GO_VERSION ?= 1.25.6
+GO_VERSION ?= 1.26.0
 DEBIAN_VERSION ?= trixie
-DISTROLESS_VERSION ?= 4.0.1
+DISTROLESS_VERSION ?= 4.0.2
 
 # Image URL to use all building/pushing image 
 ## TODO: update this to the correct image location

operator/deps.mk

@@ -36,7 +36,7 @@ ifndef ARCH
 endif
 
 ## versions
-GOLANGCI_LINT_VERSION ?= v2.7.2
+GOLANGCI_LINT_VERSION ?= v2.10.1
 KUSTOMIZE_VERSION ?= v5.4.1
 CONTROLLER_TOOLS_VERSION ?= v0.18.0
 ENVTEST_K8S_VERSION ?= 1.35.0

operator/go.mod

@@ -1,6 +1,6 @@
 module github.com/NVIDIA/skyhook/operator
 
-go 1.25.6
+go 1.26.0
 
 require (
 	github.com/go-logr/logr v1.4.3

operator/internal/controller/skyhook_controller.go

@@ -1386,7 +1386,7 @@ func fudgeInterruptWithPriority(next []*v1alpha1.Package, configUpdates map[stri
 		}
 	}
 
-	packageNames := make([]string, 0)
+	packageNames := make([]string, 0, len(next))
 	for _, pkg := range next {
 		packageNames = append(packageNames, pkg.Name)
 	}

operator/internal/controller/webhook_controller.go

@@ -476,7 +476,7 @@ func skyhookRules() []admissionregistrationv1.RuleWithOperations {
 func deploymentPolicyValidatingRules() []admissionregistrationv1.RuleWithOperations {
 	mutrules := deploymentPolicyMutatingRules()
 	oprs := mutrules[0].Operations
-	newops := make([]admissionregistrationv1.OperationType, len(oprs))
+	newops := make([]admissionregistrationv1.OperationType, 0, len(oprs)+1)
 	copy(newops, oprs)
 	newops = append(newops, admissionregistrationv1.Delete)
 	mutrules[0].Operations = newops

operator/internal/graph/dependency_graph.go

@@ -109,7 +109,7 @@ func (d *dag[T]) Add(name string, object T, dependencies ...string) error {
 
 // leaves handle edge cases where there are more then one leaf, and from is a subset of the leaves not in the from
 func (d *dag[T]) leaves(from []string) []string {
-	leaves := make([]string, 0)
+	leaves := make([]string, 0, len(d.leafs))
 	for _, f := range d.leafs {
 		leaves = append(leaves, f.name)
 	}
@@ -122,7 +122,7 @@ func (d *dag[T]) leaves(from []string) []string {
 
 // diff returns the elements in a that are not in b
 func diff(a, b []string) []string {
-	ret := make([]string, 0)
+	ret := make([]string, 0, len(a))
 	for _, v := range a {
 		if !slices.Contains(b, v) {
 			ret = append(ret, v)
@@ -179,7 +179,7 @@ func (d *dag[T]) Next(from ...string) ([]string, error) {
 }
 
 func (d *dag[T]) Get(from ...string) []T {
-	ret := make([]T, 0)
+	ret := make([]T, 0, len(from))
 	for _, f := range from {
 		ret = append(ret, d.vertices[f].object)
 	}
@@ -188,7 +188,7 @@ func (d *dag[T]) Get(from ...string) []T {
 
 func (d *dag[T]) Valid() error {
 	if len(d.placeholders) > 0 {
-		miss := make([]string, 0)
+		miss := make([]string, 0, len(d.placeholders))
 		for k := range d.placeholders {
 			miss = append(miss, k)
 		}
@@ -198,7 +198,7 @@ func (d *dag[T]) Valid() error {
 }
 
 func flat[T any](m map[string]*vertex[T]) []*vertex[T] {
-	root := make([]*vertex[T], 0)
+	root := make([]*vertex[T], 0, len(m))
 	for _, val := range m {
 		root = append(root, val)
 	}
@@ -214,7 +214,7 @@ func sortEdges[T any](e []*vertex[T]) {
 }
 
 func getNames[T any](vs []*vertex[T]) []string {
-	ret := make([]string, 0)
+	ret := make([]string, 0, len(vs))
 	for _, v := range vs {
 		ret = append(ret, v.name)
 	}