Commit bd7f8eb
committed
Address revans2/res-life review: simplify LIKE escape validation
- Replace StringUtils.escapeLikeRegex call with a focused O(n) escape
char validation that only checks the two invalid cases (escape char
at end of pattern, escape char followed by non-special character).
This avoids building a full regex string during planning.
- Remove runtime safety net in GpuLike.doColumnar — tagExprForGpu
already prevents GpuLike from being created for invalid patterns.
- Remove now-unused StringUtils import from stringFunctions.scala.
Signed-off-by: Allen Xu <allxu@nvidia.com>
Made-with: Cursor
Signed-off-by: Allen Xu <allxu@nvidia.com>1 parent 0e1b4ad commit bd7f8eb
File tree
2 files changed
+25
-22
lines changed- sql-plugin/src/main/scala
- com/nvidia/spark/rapids
- org/apache/spark/sql/rapids
2 files changed
+25
-22
lines changedLines changed: 25 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3502 | 3502 | | |
3503 | 3503 | | |
3504 | 3504 | | |
3505 | | - | |
3506 | | - | |
3507 | | - | |
3508 | | - | |
3509 | | - | |
3510 | | - | |
3511 | | - | |
3512 | | - | |
3513 | | - | |
3514 | | - | |
3515 | | - | |
3516 | | - | |
3517 | | - | |
3518 | | - | |
| 3505 | + | |
| 3506 | + | |
| 3507 | + | |
| 3508 | + | |
| 3509 | + | |
| 3510 | + | |
| 3511 | + | |
| 3512 | + | |
| 3513 | + | |
| 3514 | + | |
| 3515 | + | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
| 3519 | + | |
| 3520 | + | |
| 3521 | + | |
| 3522 | + | |
| 3523 | + | |
| 3524 | + | |
| 3525 | + | |
| 3526 | + | |
| 3527 | + | |
| 3528 | + | |
| 3529 | + | |
3519 | 3530 | | |
3520 | 3531 | | |
3521 | 3532 | | |
| |||
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
977 | 976 | | |
978 | 977 | | |
979 | 978 | | |
980 | | - | |
981 | | - | |
982 | 979 | | |
983 | 980 | | |
984 | 981 | | |
985 | 982 | | |
986 | 983 | | |
987 | 984 | | |
988 | | - | |
989 | | - | |
990 | | - | |
991 | | - | |
992 | | - | |
993 | 985 | | |
994 | 986 | | |
995 | 987 | | |
| |||
0 commit comments