try to clean up some clangd errors

Author: ericniebler

.clang-tidy

@@ -13,7 +13,6 @@ ImplementationFileExtensions:
   - cpp
   - cxx
 HeaderFilterRegex: ''
-AnalyzeTemporaryDtors: false
 FormatStyle:     none
 User:            eniebler
 CheckOptions:

.clangd

@@ -6,22 +6,33 @@ If:
 
 ---
 
-# Apply a config conditionally to all C++ files
+# Apply a config conditionally to all C++ files except those in the
+# include/execpools directory which need platform-dependent headers
 If:
-  PathMatch: .*\.(c|h)pp
+  PathMatch: .*\.(c|h)pp$
+  PathExclude: .*/execpools/.*
 
 ---
 
 # Apply a config conditionally to all CUDA files
 If:
-  PathMatch: .*\.cuh?
+  PathMatch: .*\.cuh?$
 CompileFlags:
   Add:
     # Allow variadic CUDA functions
     - "-Xclang=-fcuda-allow-variadic-functions"
 
 ---
 
+# The following file assumes a define.
+If:
+  PathMatch: .*/__system_context_default_impl_entry\.hpp
+CompileFlags:
+  Add:
+    - "-DSTDEXEC_SYSTEM_CONTEXT_INLINE=inline"
+
+---
+
 # Use clang++ in CUDA mode to provide intellisense for files with `nvexec` in their path
 If:
   PathMatch: (include|examples|test)/nvexec.*
@@ -70,3 +81,5 @@ Diagnostics:
     # The NVHPC version of _NVCXX_EXPAND_PACK macro triggers this clang error.
     # Temporarily suppressing it, but should probably fix
     - "template_param_shadow"
+    - "pp_expr_bad_token_binop" # erroneous error from STDEXEC_ENABLE_EXTRA_TYPE_CHECKING()
+    - "#warnings"

include/exec/__detail/__bit_cast.hpp

@@ -26,7 +26,6 @@
 #endif
 
 #include <cstring>
-#include <type_traits>
 
 namespace exec {
 

include/exec/__detail/__bwos_lifo_queue.hpp

@@ -24,7 +24,6 @@
 #include <cstddef>
 #include <cstdint>
 #include <memory>
-#include <new>
 #include <utility>
 #include <vector>
 

include/exec/__detail/__numa.hpp

@@ -17,13 +17,15 @@
 #pragma once
 
 #include "../../stdexec/__detail/__config.hpp"
-#include "../scope.hpp"
+#include "../../stdexec/__detail/__meta.hpp"
+#include "../scope.hpp" // IWYU pragma: keep
 
-#include <algorithm>
+#include <algorithm> // IWYU pragma: keep
 #include <cstddef>
 #include <memory>
-#include <new>
+#include <new> // IWYU pragma: keep
 #include <thread>
+#include <utility>
 
 // Work around a bug in the NVHPC compilers prior to version 24.03
 #if STDEXEC_NVHPC()

include/exec/__detail/__system_context_default_impl.hpp

@@ -233,7 +233,7 @@ namespace exec::__system_context_default_impl {
     }
   };
 
-  void* __default_query_system_context_interface(const __uuid& __id) noexcept {
+  inline void* __default_query_system_context_interface(const __uuid& __id) noexcept {
     if (__id == system_scheduler::__interface_identifier) {
       return __instance_holder::__singleton().__get_current_instance();
     } else if (__id == __system_context_replaceability::__interface_identifier) {

include/exec/__detail/__system_context_default_impl_entry.hpp

@@ -21,7 +21,7 @@
 #  error "STDEXEC_SYSTEM_CONTEXT_INLINE must be defined before including this header"
 #endif
 
-#include "__system_context_default_impl.hpp"
+#include "__system_context_default_impl.hpp" // IWYU pragma: keep
 
 STDEXEC_PRAGMA_PUSH()
 STDEXEC_PRAGMA_IGNORE_GNU("-Wattributes") // warning: inline function '[...]' declared weak

include/exec/__detail/__system_context_replaceability_api.hpp

@@ -17,13 +17,12 @@
 #ifndef STDEXEC_SYSTEM_CONTEXT_REPLACEABILITY_API_H
 #define STDEXEC_SYSTEM_CONTEXT_REPLACEABILITY_API_H
 
-#include "stdexec/__detail/__execution_fwd.hpp"
-
-#include <typeindex>
+#include <cstdint>
+#include <exception>
 
 struct __uuid {
-  uint64_t __parts1;
-  uint64_t __parts2;
+  std::uint64_t __parts1;
+  std::uint64_t __parts2;
 
   friend bool operator==(__uuid, __uuid) noexcept = default;
 };
@@ -37,7 +36,8 @@ namespace exec::system_context_replaceability {
   template <__uuid X>
   using __check_constexpr_uuid = void;
 
-  //! Concept for a queryable interface. Ensures that the interface has a `__interface_identifier` member.
+  //! Concept for a queryable interface. Ensures that the interface has a `__interface_identifier`
+  //! member.
   template <typename _T>
   concept __queryable_interface =
     requires() { typename __check_constexpr_uuid<_T::__interface_identifier>; };
@@ -49,8 +49,8 @@ namespace exec::system_context_replaceability {
       __query_system_context_interface(_Interface::__interface_identifier));
   }
 
-  /// Interface for completing a sender operation.
-  /// Backend will call frontend though this interface for completing the `schedule` and `schedule_bulk` operations.
+  /// Interface for completing a sender operation. Backend will call frontend though this interface
+  /// for completing the `schedule` and `schedule_bulk` operations.
   struct receiver {
     virtual ~receiver() = default;
 
@@ -65,14 +65,14 @@ namespace exec::system_context_replaceability {
   /// Receiver for bulk sheduling operations.
   struct bulk_item_receiver : receiver {
     /// Called for each item of a bulk operation, possible on different threads.
-    virtual void start(uint32_t) noexcept = 0;
+    virtual void start(std::uint32_t) noexcept = 0;
   };
 
   /// Describes a storage space.
   /// Used to pass preallocated storage from the frontend to the backend.
   struct storage {
     void* __data;
-    uint32_t __size;
+    std::uint32_t __size;
   };
 
   /// Interface for the system scheduler
@@ -81,10 +81,13 @@ namespace exec::system_context_replaceability {
 
     virtual ~system_scheduler() = default;
 
-    /// Schedule work on system scheduler, calling `__r` when done and using `__s` for preallocated memory.
+    /// Schedule work on system scheduler, calling `__r` when done and using `__s` for preallocated
+    /// memory.
     virtual void schedule(storage __s, receiver* __r) noexcept = 0;
-    /// Schedule bulk work of size `__n` on system scheduler, calling `__r` for each item and then when done, and using `__s` for preallocated memory.
-    virtual void bulk_schedule(uint32_t __n, storage __s, bulk_item_receiver* __r) noexcept = 0;
+    /// Schedule bulk work of size `__n` on system scheduler, calling `__r` for each item and then
+    /// when done, and using `__s` for preallocated memory.
+    virtual void
+      bulk_schedule(std::uint32_t __n, storage __s, bulk_item_receiver* __r) noexcept = 0;
   };
 
   /// Implementation-defined mechanism for replacing the system scheduler backend at run-time.
@@ -98,4 +101,4 @@ namespace exec::system_context_replaceability {
 
 } // namespace exec::system_context_replaceability
 
-#endif
+#endif

include/exec/__detail/intrusive_heap.hpp

@@ -20,6 +20,7 @@
 
 #include <cstddef>
 #include <bit>
+#include <utility>
 
 STDEXEC_PRAGMA_PUSH()
 STDEXEC_PRAGMA_IGNORE_EDG(not_used_in_partial_spec_arg_list)

include/exec/any_sender_of.hpp

@@ -15,11 +15,9 @@
  */
 #pragma once
 
-#include "../stdexec/concepts.hpp"
 #include "../stdexec/execution.hpp"
-#include "../stdexec/functional.hpp"
 
-#include "./sequence_senders.hpp"
+#include "sequence_senders.hpp"
 
 #include <cstddef>
 #include <utility>