Skip to content

Commit 29b3788

Browse files
committed
updated variables
1 parent 3f31828 commit 29b3788

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

pkg/vgpu/config.go

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -62,35 +62,35 @@ func (m *nvlibVGPUConfigManager) GetVGPUConfigforVFIO(gpu int) (types.VGPUConfig
6262
return nil, fmt.Errorf("unable to get GPU by index %d: %v", gpu, err)
6363
}
6464
vgpuConfig := types.VGPUConfig{}
65-
VFnum := 0
65+
vfnum := 0
6666
if nvdevice.SriovInfo.PhysicalFunction == nil {
6767
return vgpuConfig, nil
6868
}
6969
totalVF := int(nvdevice.SriovInfo.PhysicalFunction.TotalVFs)
70-
for VFnum < totalVF {
71-
VFAddr := HostPCIDevicesRoot + "/" + nvdevice.Address + "/virtfn" + strconv.Itoa(VFnum) + "/nvidia"
72-
if _, err := os.Stat(VFAddr); err != nil {
73-
VFnum++
70+
for vfnum < totalVF {
71+
vfAddr := HostPCIDevicesRoot + "/" + nvdevice.Address + "/virtfn" + strconv.Itoa(vfnum) + "/nvidia"
72+
if _, err := os.Stat(vfAddr); err != nil {
73+
vfnum++
7474
continue
7575
}
76-
VGPUTypeNumberBytes, err := os.ReadFile(VFAddr + "/current_vgpu_type")
76+
vgpuTypeNumberBytes, err := os.ReadFile(vfAddr + "/current_vgpu_type")
7777
if err != nil {
7878
return nil, fmt.Errorf("unable to read current vGPU type: %v", err)
7979
}
80-
VGPUTypeNumber, err := strconv.Atoi(strings.TrimSpace(string(VGPUTypeNumberBytes)))
80+
vgpuTypeNumber, err := strconv.Atoi(strings.TrimSpace(string(vgpuTypeNumberBytes)))
8181
if err != nil {
8282
return nil, fmt.Errorf("unable to convert current vGPU type to int: %v", err)
8383
}
84-
if VGPUTypeNumber == 0 {
85-
VFnum++
84+
if vgpuTypeNumber == 0 {
85+
vfnum++
8686
continue
8787
}
88-
VGPUTypeName, err := m.getVGPUTypeNameforVFIO(VFAddr + "/creatable_vgpu_types", VGPUTypeNumber)
88+
vgpuTypeName, err := m.getVGPUTypeNameforVFIO(vfAddr + "/creatable_vgpu_types", vgpuTypeNumber)
8989
if err != nil {
9090
return nil, fmt.Errorf("unable to get vGPU type name: %v", err)
9191
}
92-
vgpuConfig[VGPUTypeName]++
93-
VFnum++
92+
vgpuConfig[vgpuTypeName]++
93+
vfnum++
9494
}
9595
return vgpuConfig, nil
9696
}
@@ -102,13 +102,13 @@ func (m *nvlibVGPUConfigManager) SetVGPUConfigforVFIO(gpu int, config types.VGPU
102102
return fmt.Errorf("unable to get GPU by index %d: %v", gpu, err)
103103
}
104104

105-
GPUDevices, err := m.nvlib.Nvpci.GetGPUs()
105+
gpuDevices, err := m.nvlib.Nvpci.GetGPUs()
106106
if err != nil {
107107
return fmt.Errorf("unable to get all NVIDIA GPU devices: %v", err)
108108
}
109109

110110
deviceFound := false
111-
for _, device := range GPUDevices {
111+
for _, device := range gpuDevices {
112112
if device.Address == nvdevice.Address {
113113
deviceFound = true
114114
break
@@ -124,20 +124,20 @@ func (m *nvlibVGPUConfigManager) SetVGPUConfigforVFIO(gpu int, config types.VGPU
124124
return fmt.Errorf("unable to execute sriov-manage: %v, output: %s", err, string(output))
125125
}
126126

127+
vfnum := 0
127128
for key, val := range config {
128129
remainingToCreate := val
129-
VFnum := 0
130130
for remainingToCreate > 0 {
131-
VFAddr := HostPCIDevicesRoot + "/" + nvdevice.Address + "/virtfn" + strconv.Itoa(VFnum) + "/nvidia"
132-
number, err := m.getVGPUTypeNumberforVFIO(VFAddr + "/creatable_vgpu_types", key)
131+
vfAddr := HostPCIDevicesRoot + "/" + nvdevice.Address + "/virtfn" + strconv.Itoa(vfnum) + "/nvidia"
132+
number, err := m.getVGPUTypeNumberforVFIO(vfAddr + "/creatable_vgpu_types", key)
133133
if err != nil {
134134
return fmt.Errorf("unable to get vGPU type number: %v", err)
135135
}
136-
err = os.WriteFile(VFAddr + "/current_vgpu_type", []byte(strconv.Itoa(number)), 0644)
136+
err = os.WriteFile(vfAddr + "/current_vgpu_type", []byte(strconv.Itoa(number)), 0644)
137137
if err != nil {
138138
return fmt.Errorf("unable to write current vGPU type: %v", err)
139139
}
140-
VFnum++
140+
vfnum++
141141
remainingToCreate--
142142
}
143143
}
@@ -191,7 +191,7 @@ func (m *nvlibVGPUConfigManager) getVGPUTypeNumberforVFIO(filePath string, vgpuT
191191
}
192192

193193
func (m *nvlibVGPUConfigManager) IsVFIOEnabled() (bool, error) {
194-
VFIOdistributions := map[string]string{
194+
vfioDistributions := map[string]string{
195195
"ubuntu": "24.04",
196196
"rhel": "10",
197197
}
@@ -202,7 +202,7 @@ func (m *nvlibVGPUConfigManager) IsVFIOEnabled() (bool, error) {
202202
}
203203

204204
content := string(data)
205-
for distribution, version := range VFIOdistributions {
205+
for distribution, version := range vfioDistributions {
206206
if strings.Contains(content, distribution) && strings.Contains(content, version) {
207207
return true, nil
208208
}

0 commit comments

Comments
 (0)