Skip to content

Commit b923064

Browse files
committed
Merge branch 'dev-3.0.6' into master
2 parents a017435 + 9748c49 commit b923064

File tree

6 files changed

+23
-62
lines changed

6 files changed

+23
-62
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
v3.0.6
2+
------
3+
- Changed max bones to 256
4+
5+
Bug Fixes:
6+
- Updated Slang to 0.10.30. Fixes SceneEditor shaders in Vulkan configs
7+
- Apply scaling transforms in animations
8+
- Fixed interpolation issues at the end of animations
9+
110
v3.0.5
211
------
312
- Added support for exporting BMP and TGA images.

Framework/Source/Data/HostDeviceSharedMacros.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
*******************************************************************/
3434

3535
#define MAX_INSTANCES 64 ///< Max supported instances per draw call
36-
#define MAX_BONES 128 ///< Max supported bones per model
36+
#define MAX_BONES 256 ///< Max supported bones per model
3737

3838
/*******************************************************************
3939
Glue code for CPU/GPU compilation

Framework/Source/Falcor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,5 +160,5 @@
160160
#define FALCOR_MAJOR_VERSION 3
161161
#define FALCOR_MINOR_VERSION 0
162162
#define FALCOR_DEV_STAGE ""
163-
#define FALCOR_DEV_REVISION 5
164-
#define FALCOR_VERSION_STRING "3.0.5"
163+
#define FALCOR_DEV_REVISION 6
164+
#define FALCOR_VERSION_STRING "3.0.6"

Framework/Source/Graphics/Model/Animation.cpp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,19 +100,22 @@ namespace Falcor
100100
assert(ticks >= curKey.time);
101101
// Interpolate between them
102102
float diff = nextKey.time - curKey.time;
103-
if(diff < 0)
104-
{
105-
diff += mDuration;
106-
}
107-
else if(diff == 0)
103+
104+
if (diff == 0)
108105
{
109106
curValue = curKey.value;
110107
}
111108
else
112109
{
110+
if (diff < 0)
111+
{
112+
diff += mDuration;
113+
}
114+
113115
float ratio = (ticks - curKey.time) / diff;
114116
curValue = interpolate(curKey.value, nextKey.value, ratio);
115117
}
118+
116119
channel.lastKeyUsed = curKeyIndex;
117120
}
118121
return curValue;
@@ -131,7 +134,7 @@ namespace Falcor
131134
glm::mat4 scaling;
132135
if (Key.scaling.keys.size() > 0)
133136
{
134-
glm::scale(calcCurrentKey(Key.scaling, ticks, Key.lastUpdateTime));
137+
scaling = glm::scale(calcCurrentKey(Key.scaling, ticks, Key.lastUpdateTime));
135138
}
136139

137140
glm::quat q = calcCurrentKey(Key.rotation, ticks, Key.lastUpdateTime);

Samples/Effects/NormalMapFiltering/Data/NormalMapFiltering.ps.hlsl

Lines changed: 0 additions & 51 deletions
This file was deleted.

dependencies.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
<package name="rapidjson" version="1.1.0" />
3030
</dependency>
3131
<dependency name="slang" linkPath="Framework/Externals/Slang">
32-
<package name="slang" version="0.10.24" remotes="github-slang" />
33-
<package name="slang" version="0.10.24" remotes="github-slang-linux" platforms="linux" />
32+
<package name="slang" version="0.10.30" remotes="github-slang" />
33+
<package name="slang" version="0.10.30" remotes="github-slang-linux" platforms="linux" />
3434
</dependency>
3535
<dependency name="glfw" linkPath="Framework/Externals/GLFW">
3636
<package name="glfw" version="3.2.1" platforms="win" />

0 commit comments

Comments
 (0)