Skip to content
This repository was archived by the owner on Jun 5, 2023. It is now read-only.

Wrong count of number of outliers and whitelisted outliers #580

@maximilienroberti

Description

@maximilienroberti

If you observe the function process_outlier() in analyzer.py you can see that self.total_outliers is incremented event if the outlier is whitelisted.
https://github.com/NVISO-BE/ee-outliers/blob/58021dc20f6cbbe411c0a6337ea39a82fc139a9d/app/helpers/analyzer.py#L220-L235
Also, I observed that the number of whitelisted outliers represented by the variable 'self.nr_whitelisted_elements' is never incremented in that function. As a result, it does not count the number of whitelisted outliers in simplequery, word2vec and sudden_appearance models.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions