add error handling tests for version bumping

Author: damonmcc

dcpy/test/utils/test_versions.py

@@ -217,6 +217,27 @@ def test_bumping_versions(self):
         ]:
             self.assertEqual(v_expected, versions.bump(v, bumped_part, bump_by).label)
 
+    def test_bumping_versions_errors(self):
+        with self.assertRaises(NotImplementedError):
+            versions.bump("2023-01-01")
+
+        with self.assertRaises(ValueError):
+            versions.bump(versions.Date(date(2023, 1, 1), format="unsupported"))
+
+        with self.assertRaises(ValueError):
+            versions.bump(
+                versions.Date(
+                    date(2023, 1, 1), format=versions.DateVersionFormat.fiscal_year
+                ),
+                bump_type=versions.VersionSubType.major,
+            )
+
+        class UnsupportedVersion:
+            pass
+
+        with self.assertRaises(ValueError):
+            versions.bump(UnsupportedVersion())
+
     def test_group_versions_by_base(self):
         for version, versions_list, expected_output in [
             [

dcpy/utils/versions.py

@@ -454,7 +454,7 @@ def bump(
         case Date(), None:
             raise ValueError(f"Unsupported date format {previous_version.format}")
         case Date(), _:
-            raise Exception(
+            raise ValueError(
                 f"Version subtype {bump_type} not applicable for Date versions"
             )
         case CapitalBudget(), None: