Skip to content

Commit 06f1ca1

Browse files
authored
Merge pull request #595 from NYPL/SCC-5041-fix-alarm-noise
[SCC-5041] Add checks to address common errors
2 parents 5fd133f + 9dd4aeb commit 06f1ca1

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/annotated-marc-serializer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ AnnotatedMarcSerializer.addStatementsForVarFieldForRule = function (doc, bib, va
322322
.pop()
323323
}
324324
})
325-
.filter((parallel) => parallelNumbers.some((parallelNumber) => parallel.linkingValue.indexOf(parallelNumber) === 4))
325+
.filter((parallel) => parallelNumbers.some((parallelNumber) => parallel.linkingValue?.indexOf(parallelNumber) === 4))
326326
.map((parallel) => parallel.field)
327327

328328
if (matchingParallels.length > 0) {

lib/jsonld_serializers.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,9 @@ class AggregationsSerializer extends JsonLdListSerializer {
490490
.map(([id, agg]) => Object.assign({ id }, agg))
491491
.map((agg) => AggregationSerializer.serialize(agg, options))
492492
)
493-
return (new AggregationsSerializer(items, Object.assign({ extraRootProperties: { totalResults: resp.hits.total } }, options))).format()
493+
494+
const hits = resp.hits?.total ?? 0
495+
return (new AggregationsSerializer(items, Object.assign({ extraRootProperties: { totalResults: hits } }, options))).format()
494496
}
495497
}
496498

0 commit comments

Comments
 (0)