move log method

Author: charmingduchess

lib/requestability_resolver.js

@@ -25,6 +25,9 @@ class RequestabilityResolver {
   }
 
   static buildPhysRequestable (item, numDeliveryLocations) {
+    function logPhysRequestableInfo (physRequestable, criteria) {
+      logger.debug(`item ${item.uri}: ${{ physRequestable, criteria }}`)
+    }
     let physRequestableCriteria
     let physRequestable
     const hasRecapCustomerCode = item.recapCustomerCode?.[0]
@@ -34,41 +37,37 @@ class RequestabilityResolver {
     if (isItemNyplOwned(item) && !hasBarcode) {
       physRequestable = false
       physRequestableCriteria = 'NYPL item missing barcode'
-      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria, item.uri)
+      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria)
       return physRequestable
     }
     if (isItemNyplOwned(item) && !DeliveryLocationsResolver.requestableBasedOnHoldingLocation(item)) {
       physRequestableCriteria = 'Unrequestable holding location'
       physRequestable = false
-      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria, item.uri)
+      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria)
       return physRequestable
     }
     if (itemIsInRecapMissingRecapCustomerCode) {
       // recap items missing codes should default to true for phys and edd
       // requestable, if it has a requestable holding location.
       physRequestable = true
       physRequestableCriteria = 'Missing customer code'
-      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria, item.uri)
+      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria)
       return physRequestable
     }
     if (numDeliveryLocations === 0) {
       physRequestableCriteria = 'No delivery locations.'
       physRequestable = false
-      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria, item.uri)
+      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria)
       return physRequestable
     }
     if (numDeliveryLocations > 0) {
       physRequestableCriteria = `${numDeliveryLocations} delivery locations.`
       physRequestable = true
-      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria, item.uri)
+      this.logPhysRequestableInfo(physRequestable, physRequestableCriteria)
       return physRequestable
     }
   }
 
-  static logPhysRequestableInfo (physRequestable, criteria, uri) {
-    logger.debug(`item ${uri}: ${{ physRequestable, criteria }}`)
-  }
-
   static buildSpecRequestable (item) {
     const holdingLocation = DeliveryLocationsResolver.extractLocationCode(item)
     const nyplCoreLocation = DeliveryLocationsResolver.nyplCoreLocation(holdingLocation)