Skip to content

Commit aa87861

Browse files
committed
Merge branch 'master' of https://github.com/UbivisDev/StompProtocolAndroid into UbivisDev-master
# Conflicts: # lib/src/main/java/ua/naiksoftware/stomp/OkHttpConnectionProvider.java
2 parents 51aaec4 + 1a5368f commit aa87861

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

lib/src/main/java/ua/naiksoftware/stomp/OkHttpConnectionProvider.java

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package ua.naiksoftware.stomp;
22

3-
import android.nfc.Tag;
43
import android.support.annotation.NonNull;
54
import android.support.annotation.Nullable;
65
import android.util.Log;
@@ -27,7 +26,7 @@ class OkHttpConnectionProvider extends AbstractConnectionProvider {
2726
private final OkHttpClient mOkHttpClient;
2827

2928
@Nullable
30-
private WebSocket openedSocked;
29+
private WebSocket openSocket;
3130

3231
OkHttpConnectionProvider(String uri, @Nullable Map<String, String> connectHttpHeaders, OkHttpClient okHttpClient) {
3332
super();
@@ -36,11 +35,10 @@ class OkHttpConnectionProvider extends AbstractConnectionProvider {
3635
mOkHttpClient = okHttpClient;
3736
}
3837

39-
@NonNull
4038
@Override
4139
public void rawDisconnect() {
42-
if (openedSocked != null) {
43-
openedSocked.close(1000, "");
40+
if (openSocket != null) {
41+
openSocket.close(1000, "");
4442
}
4543
}
4644

@@ -51,7 +49,7 @@ void createWebSocketConnection() {
5149

5250
addConnectionHeadersToBuilder(requestBuilder, mConnectHttpHeaders);
5351

54-
openedSocked = mOkHttpClient.newWebSocket(requestBuilder.build(),
52+
openSocket = mOkHttpClient.newWebSocket(requestBuilder.build(),
5553
new WebSocketListener() {
5654
@Override
5755
public void onOpen(WebSocket webSocket, @NonNull Response response) {
@@ -78,17 +76,15 @@ public void onMessage(WebSocket webSocket, @NonNull ByteString bytes) {
7876

7977
@Override
8078
public void onClosed(WebSocket webSocket, int code, String reason) {
81-
if (webSocket != openedSocked) return;
82-
openedSocked = null;
79+
openSocket = null;
8380
emitLifecycleEvent(new LifecycleEvent(LifecycleEvent.Type.CLOSED));
8481
}
8582

8683
@Override
8784
public void onFailure(WebSocket webSocket, Throwable t, Response response) {
88-
if (webSocket != openedSocked) return;
8985
// in OkHttp, a Failure is equivalent to a JWS-Error *and* a JWS-Close
9086
emitLifecycleEvent(new LifecycleEvent(LifecycleEvent.Type.ERROR, new Exception(t)));
91-
openedSocked = null;
87+
openSocket = null;
9288
emitLifecycleEvent(new LifecycleEvent(LifecycleEvent.Type.CLOSED));
9389
}
9490

@@ -103,13 +99,13 @@ public void onClosing(final WebSocket webSocket, final int code, final String re
10399

104100
@Override
105101
void rawSend(String stompMessage) {
106-
openedSocked.send(stompMessage);
102+
openSocket.send(stompMessage);
107103
}
108104

109105
@Nullable
110106
@Override
111107
Object getSocket() {
112-
return openedSocked;
108+
return openSocket;
113109
}
114110

115111
@NonNull

lib/src/main/java/ua/naiksoftware/stomp/WebSocketsConnectionProvider.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,12 @@ class WebSocketsConnectionProvider extends AbstractConnectionProvider {
4848

4949
@Override
5050
public void rawDisconnect() {
51-
mWebSocketClient.close();
51+
try {
52+
mWebSocketClient.closeBlocking();
53+
} catch (InterruptedException e) {
54+
Log.e(TAG, "Thread interrupted while waiting for Websocket closing: ", e);
55+
throw new RuntimeException(e);
56+
}
5257
}
5358

5459
@Override

0 commit comments

Comments
 (0)