Skip to content

Commit c68c6aa

Browse files
authored
Merge branch 'master' into npe-on-dispose
2 parents 5871667 + b55536b commit c68c6aa

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/src/main/java/ua/naiksoftware/stomp/OkHttpConnectionProvider.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ public void onClosed(WebSocket webSocket, int code, String reason) {
106106
public void onFailure(WebSocket webSocket, Throwable t, Response response) {
107107
emitLifecycleEvent(new LifecycleEvent(LifecycleEvent.Type.ERROR, new Exception(t)));
108108
}
109+
110+
@Override
111+
public void onClosing(final WebSocket webSocket, final int code, final String reason) {
112+
webSocket.close(code, reason);
113+
}
109114
}
110115

111116
);

lib/src/main/java/ua/naiksoftware/stomp/client/StompClient.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public class StompClient {
3434
public static final String DEFAULT_ACK = "auto";
3535

3636
private Disposable mMessagesDisposable;
37+
private Disposable mLifecycleDisposable;
3738
private Map<String, Set<FlowableEmitter<? super StompMessage>>> mEmitters = new ConcurrentHashMap<>();
3839
private List<ConnectableFlowable<Void>> mWaitConnectionFlowables;
3940
private final ConnectionProvider mConnectionProvider;
@@ -74,7 +75,7 @@ public void connect(List<StompHeader> _headers) {
7475
public void connect(List<StompHeader> _headers, boolean reconnect) {
7576
if (reconnect) disconnect();
7677
if (mConnected) return;
77-
mConnectionProvider.getLifecycleReceiver()
78+
mLifecycleDisposable = mConnectionProvider.getLifecycleReceiver()
7879
.subscribe(lifecycleEvent -> {
7980
switch (lifecycleEvent.getType()) {
8081
case OPENED:
@@ -156,6 +157,7 @@ public Flowable<LifecycleEvent> lifecycle() {
156157

157158
public void disconnect() {
158159
if (mMessagesDisposable != null) mMessagesDisposable.dispose();
160+
if (mLifecycleDisposable != null) mLifecycleDisposable.dispose();
159161
mConnected = false;
160162
}
161163

0 commit comments

Comments
 (0)