Skip to content

Commit 1281610

Browse files
committed
remove compare filds in time condition
1 parent d49f42d commit 1281610

File tree

2 files changed

+2
-45
lines changed

2 files changed

+2
-45
lines changed

executor/engine/job/condition.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -291,24 +291,12 @@ class AfterTimepoint(TimeCondition):
291291
292292
Attributes:
293293
timepoint: The timepoint.
294-
compare_fields: The fields to compare.
295-
Fields: "year", "month", "day", "hour", "minute", "second"
296294
"""
297295

298296
timepoint: datetime
299-
compare_fields: T.Optional[T.List[str]] = None
300297

301298
def satisfy(self, _) -> bool:
302-
if self.compare_fields is None:
303-
return datetime.now() > self.timepoint
304-
else:
305-
for field in self.compare_fields:
306-
if field not in _valid_timepoint_fields:
307-
raise ValueError(f"Invalid field: {field}")
308-
if getattr(datetime.now(), field) >= \
309-
getattr(self.timepoint, field):
310-
return False
311-
return True
299+
return datetime.now() > self.timepoint
312300

313301

314302
@dataclass
@@ -317,20 +305,8 @@ class BeforeTimepoint(TimeCondition):
317305
318306
Attributes:
319307
timepoint: The timepoint.
320-
compare_fields: The fields to compare.
321-
Fields: "year", "month", "day", "hour", "minute", "second"
322308
"""
323309
timepoint: datetime
324-
compare_fields: T.Optional[T.List[str]] = None
325310

326311
def satisfy(self, _) -> bool:
327-
if self.compare_fields is None:
328-
return datetime.now() < self.timepoint
329-
else:
330-
for field in self.compare_fields:
331-
if field not in _valid_timepoint_fields:
332-
raise ValueError(f"Invalid field: {field}")
333-
if getattr(datetime.now(), field) <= \
334-
getattr(self.timepoint, field):
335-
return False
336-
return True
312+
return datetime.now() < self.timepoint

tests/test_condition.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -226,25 +226,6 @@ def test_time_condition():
226226
assert BeforeClock("23:59:59").satisfy(None)
227227
assert AfterTimepoint(datetime.now() - timedelta(hours=1)).satisfy(None)
228228
assert BeforeTimepoint(datetime.now() + timedelta(hours=1)).satisfy(None)
229-
assert AfterTimepoint(
230-
datetime.now() + timedelta(hours=1), compare_fields=["hour"]
231-
).satisfy(None)
232-
assert BeforeTimepoint(
233-
datetime.now() - timedelta(hours=1), compare_fields=["hour"]
234-
).satisfy(None)
235-
assert not AfterTimepoint(
236-
datetime.now() - timedelta(hours=1), compare_fields=["hour"]
237-
).satisfy(None)
238-
assert not BeforeTimepoint(
239-
datetime.now() + timedelta(hours=1), compare_fields=["hour"]
240-
).satisfy(None)
241229
assert AfterWeekday("mon").satisfy(None)
242230
assert BeforeWeekday("sun").satisfy(None)
243231

244-
with pytest.raises(ValueError):
245-
AfterTimepoint(
246-
datetime.now(), compare_fields=["not_exist"]).satisfy(None)
247-
248-
with pytest.raises(ValueError):
249-
BeforeTimepoint(
250-
datetime.now(), compare_fields=["not_exist"]).satisfy(None)

0 commit comments

Comments
 (0)