Skip to content

Implement proper integration weights in cylindrical coordinates #2467

@smartalecH

Description

@smartalecH

As discussed in #2452, the integration weights in cylindrical coordinates are implemented identically as those in cartesian coordinates (which is incorrect). The procedure to fix this is outlined in the code itself:

meep/src/loop_in_chunks.cpp

Lines 112 to 113 in 1fe3899

Integration Weights in Cylindrical Coordinates
FIXME: implement this below?

but it's not trivial to implement, particularly with cases at or crossing r=0 (which happens a lot...)

Anecdotally, this doesn't seem to be an issue if R is rather large. However, for smaller cells, the error compounds substantially (and doesn't "easily" disappear with resolution).

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions