Skip to content

Commit 91b8832

Browse files
authored
fix: add permissions to ci and change release process (#179)
* fix: fix release ci permissions and docs around actions util * chore: add tmp code to fix releases issue * fix: change changelog in github release * fix: fix ecs server changelog * chore: add tmp code to fix releases issue * revert: tmp code to fix releases issue
1 parent 7df2037 commit 91b8832

File tree

10 files changed

+28
-5
lines changed

10 files changed

+28
-5
lines changed

.github/ISSUE_TEMPLATE/01-packages_bug_report.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ body:
2626
- network-client
2727
- network-server
2828
- sound
29+
- other
2930
validations:
3031
required: true
3132
- type: textarea

.github/ISSUE_TEMPLATE/02-utils_bug_report.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ body:
1313
attributes:
1414
label: Which utils is this bug report for?
1515
options:
16+
- actions
1617
- eslint-config
1718
- prettier-config
19+
- other
1820
validations:
1921
required: true
2022
- type: textarea

.github/ISSUE_TEMPLATE/03-feature_request.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@ body:
2424
- network-client
2525
- network-server
2626
- sound
27+
- actions
2728
- eslint-config
2829
- prettier-config
30+
- other
2931
validations:
3032
required: true
3133
- type: textarea

.github/issue-labeler.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,14 @@ packages:sound:
5050
- "### Which (package|utils|package or utils) is this (bug
5151
report|feature request) for\\?\\n\\nsound\\n"
5252

53+
utils:actions:
54+
- "### Which (package|utils|package or utils) is this (bug
55+
report|feature request) for\\?\\n\\nactions\\n"
56+
5357
utils:eslint-config:
5458
- "### Which (package|utils|package or utils) is this (bug
55-
report|feature request) for\\?\\n\\nstructures\\n"
59+
report|feature request) for\\?\\n\\neslint-config\\n"
5660

5761
utils:prettier-config:
5862
- "### Which (package|utils|package or utils) is this (bug
59-
report|feature request) for\\?\\n\\ui\\n"
63+
report|feature request) for\\?\\n\\nprettier-config\\n"

.github/labeler.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ packages:sound:
7676
- packages/sound/*
7777
- packages/sound/**/*
7878

79+
utils:actions:
80+
- changed-files:
81+
- any-glob-to-any-file:
82+
- utils/actions/*
83+
- utils/actions/**/*
84+
7985
utils:eslint-config:
8086
- changed-files:
8187
- any-glob-to-any-file:

.github/labels.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@
102102
description: "Adding missing tests or correcting existing tests"
103103
color: "7f8f92"
104104

105+
- name: "utils:actions"
106+
description: "Related to Github actions"
107+
color: "606bdf"
108+
105109
- name: "utils:eslint-config"
106110
description: "Related to ESLint config"
107111
color: "606bdf"

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ on:
3838
env:
3939
EM_CACHE_FOLDER: "emsdk-cache"
4040

41+
permissions:
42+
contents: write
43+
4144
jobs:
4245
npm-publish:
4346
name: npm publish

packages/ecs-server/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
All notable changes to this project will be documented in this file.
44

5-
# [@nanoforge-dev/ecs-server@0.0.1](https://github.com/NanoForge-dev/Engine/tree/@nanoforge-dev/ecs-server@0.0.1) - (2026-01-09)
5+
# [@nanoforge-dev/ecs-server@1.0.0](https://github.com/NanoForge-dev/Engine/tree/@nanoforge-dev/ecs-server@0.0.1) - (2026-01-09)
66

77
## Bug Fixes
88

utils/actions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"lint": "prettier --check . && eslint --format=pretty src",
3939
"format": "prettier --write . && eslint --fix --format=pretty src",
4040
"prepack": "pnpm run build && pnpm run lint",
41-
"changelog": "git cliff --prepend ./CHANGELOG.md -u -c ./cliff.toml -r ../../ --include-path 'packages/actions/*'",
41+
"changelog": "git cliff --prepend ./CHANGELOG.md -u -c ./cliff.toml -r ../../ --include-path 'utils/actions/*'",
4242
"release": "cliff-jumper"
4343
},
4444
"dependencies": {

utils/actions/src/release-packages/generate-release-tree.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,15 @@ async function getReleaseEntries(dry: boolean, devTag?: string) {
111111
}
112112

113113
foundChangelog = true;
114+
continue;
114115
}
115116

116117
if (foundChangelog) {
117118
changelogLines.push(line);
118119
}
119120
}
120121

121-
release.changelog = changelogLines.join("\n");
122+
release.changelog = `${changelogLines.join("\n").replace(/^\s+|\s+$/g, "")}\n`;
122123
} catch (error) {
123124
// Probably just no changelog file but log just in case
124125
warning(`Error parsing changelog for ${pkg.name}, will use auto generated: ${error}`);

0 commit comments

Comments
 (0)