Merge pull request PHPCSStandards#1124 from PHPCSStandards/php-8.4/feature/squiz-scopekeywordspacing-support-asym-visibility

Squiz/ScopeKeywordSpacing: update for properties with asymmetric visibility

Author: jrfnl

src/Standards/Squiz/Sniffs/WhiteSpace/ScopeKeywordSpacingSniff.php

@@ -24,8 +24,9 @@ class ScopeKeywordSpacingSniff implements Sniff
      */
     public function register()
     {
-        $register   = Tokens::$methodPrefixes;
-        $register[] = T_READONLY;
+        $register  = Tokens::$methodPrefixes;
+        $register += Tokens::$scopeModifiers;
+        $register[T_READONLY] = T_READONLY;
         return $register;
 
     }//end register()

src/Standards/Squiz/Tests/WhiteSpace/ScopeKeywordSpacingUnitTest.1.inc

@@ -192,3 +192,13 @@ class FinalProperties {
     final readonly public ?MyType $spacing_correct;
     protected   final   $spacing_incorrect = 'foo';
 }
+
+class AsymVisibility {
+    public(set)      string $asymPublic  = 'hello';
+    public  protected(set)   final  $asymProtected  = 'hello';
+    private(set)     public   string|false $asymPrivate  = 'hello';
+
+    public public(set) $asymPublicPublic  = 'hello';
+    protected(set) public $asymPublicProtected  = 'hello';
+    protected private(set) $asymProtectedPrivate  = 'hello';
+}

src/Standards/Squiz/Tests/WhiteSpace/ScopeKeywordSpacingUnitTest.1.inc.fixed

@@ -185,3 +185,13 @@ class FinalProperties {
     final readonly public ?MyType $spacing_correct;
     protected final $spacing_incorrect = 'foo';
 }
+
+class AsymVisibility {
+    public(set) string $asymPublic  = 'hello';
+    public protected(set) final $asymProtected  = 'hello';
+    private(set) public string|false $asymPrivate  = 'hello';
+
+    public public(set) $asymPublicPublic  = 'hello';
+    protected(set) public $asymPublicProtected  = 'hello';
+    protected private(set) $asymProtectedPrivate  = 'hello';
+}

src/Standards/Squiz/Tests/WhiteSpace/ScopeKeywordSpacingUnitTest.php

@@ -70,6 +70,9 @@ public function getErrorList($testFile='')
                 187 => 1,
                 188 => 1,
                 193 => 2,
+                197 => 1,
+                198 => 3,
+                199 => 2,
             ];
 
         case 'ScopeKeywordSpacingUnitTest.3.inc':