Fix adding new settings array (#434)

This fixes an issue with plugins that use the new "array" setting
type. The array setting type allows you to specify an arbitrary
number of items for a setting. For instance, you could define
"user" as type "array" and then have a name and email address
defined for each user.

The issue is that when first creating the setting, I was treating
the subsettings like dictionaries, but they are actually a tuple
of tuples, with the first representing the path and the second
the definition.

The new "array" type setting is necessary, but overly complex. I
wish I could come up with a simpler implementation.

Anyway, this fixes a "TypeError" error when attempting to prompt
the user for a value for an "array" setting that has not been
initialized before.

Author: aaronchantrill

naomi/commandline.py

@@ -407,10 +407,17 @@ def get_setting(self, setting, definition):
                     first = True
                     newarray = [part for part in setting]
                     newarray.extend([currentvalue])
-                    for subsetting in definition['each']:
+                    for settingindex in range(len(definition['each'])):
+                        subsetting = definition['each'][settingindex]
                         newsetting = newarray.copy()
-                        newsetting.extend([subsetting[0]])
-                        self.get_setting(tuple(newsetting), definition['each'][subsetting])
+                        # Subsetting looks something like:
+                        # (('id',), {'title': 'ID of your light', 'description': 'The ID of your light as reported by HomeAssistant'})
+                        # subsetting[0] could be a path with multiple nodes
+                        # subsetting[1] is the definition of this setting
+                        # Add the path nodes to newsetting
+                        for subnode in subsetting[0]:
+                            newsetting.append(subnode)
+                        self.get_setting(tuple(newsetting), subsetting[1])
                         if first:
                             first = False
                             if not profile.get(newsetting):