Merge branch 'patch' into iph-dispatch

Author: sjanzou

.github/pull_request_template.md

@@ -1,33 +1,32 @@
-# Pull Request Template
+## Pull Request Template
 
-## Description
+### Description
+[ description of the bug fix or new functionality ]
 
-Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
+[ include directions for reviewers if necessary- what or how should they test or review ]
 
-Fixes # (issue)
+Fixes # (issue(s))
 
-## Type of change
+### Corresponding branches and PRs:
+[ which branches of wex, lk, and ssc should be built with this PR ]
 
-Please delete options that are not relevant.
+[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
 
-- [ ] Bug fix (non-breaking change which fixes an issue)
-- [ ] New feature (non-breaking change which adds functionality)
-- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
-- [ ] This change requires a documentation update
-- [ ] This change modifies variables in existing compute modules. Please see [Checking for PySAM Incompatible API Changes](https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
-- [ ] This change requires updating the PySAM files via export_config. Please see [When do the PySAM files need to be regenerated?](https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)
+### Unit Test Impact:
+[ new tests written? ]
 
+[ expected changes in unit tests or speed of tests? ]
 
-## Checklist:
+[ expected changes in test_results files? ]
 
-If you have added a new compute module in a SSC pull request related to this one, be sure to check the [Process Requirements](https://github.com/NREL/SAM/wiki/Compute-modules-in-SAM).
+### Checklist
+- [ ] requires help revision and I added that label
+- [ ] adds, removes, modifies, or deletes variables in existing compute modules
+- [ ] adds a new compute module
+- [ ] changes defaults
+- [ ] I've tagged this PR to a milestone
 
-- [ ] My code follows the style guidelines of this project
-- [ ] I have performed a self-review of my own code
-- [ ] I have commented my code, particularly in hard-to-understand areas
-- [ ] I have made corresponding changes to the documentation
-- [ ] My changes generate no new warnings
-- [ ] I have added tests that prove my fix is effective or that my feature works
-- [ ] New and existing unit tests pass locally with my changes
-- [ ] Any dependent changes have been merged and published in downstream modules
-- [ ] I have checked my code and corrected any misspellings
+### _Reminders- this section can be deleted_
+[Checking for PySAM Incompatible API Changes](https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
+
+[When do the PySAM files need to be regenerated?](https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

api/api_autogen/library/defaults/CashloanHeat_MSLFIPHCommercial.json

@@ -181,10 +181,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/CashloanHeat_PhysicalTroughIPHCommercial.json

@@ -23,7 +23,7 @@
 			"om_fixed_escal": 0,
 			"om_production_escal": 0,
 			"om_production_heat": [2.000000],
-			"total_installed_cost": 1.33794e+07
+			"total_installed_cost": 1.36747e+07
 		},
 		"LandLease": {
 		},
@@ -181,10 +181,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/Cashloan_CustomGenerationBatteryCommercial.json

@@ -193,10 +193,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 1
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0,
 			"battery_total_cost_lcos": 412308

api/api_autogen/library/defaults/Cashloan_CustomGenerationBatteryResidential.json

@@ -189,10 +189,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 1
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0,
 			"battery_total_cost_lcos": 9242.27

api/api_autogen/library/defaults/Cashloan_CustomGenerationProfileCommercial.json

@@ -181,10 +181,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/Cashloan_CustomGenerationProfileResidential.json

@@ -177,10 +177,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/Cashloan_DSLFCommercial.json

@@ -28,9 +28,6 @@
 			"total_installed_cost": 3.76691e+08
 		},
 		"LandLease": {
-			"land_area": 347.641,
-			"om_land_lease": [0.000000],
-			"om_land_lease_escal": 0
 		},
 		"Depreciation": {
 			"depr_fed_custom": [0.000000],
@@ -182,10 +179,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/Cashloan_EmpiricalTroughCommercial.json

@@ -28,9 +28,6 @@
 			"total_installed_cost": 5.28448e+08
 		},
 		"LandLease": {
-			"land_area": 890.324,
-			"om_land_lease": [0.000000],
-			"om_land_lease_escal": 0
 		},
 		"Depreciation": {
 			"depr_fed_custom": [0.000000],
@@ -182,10 +179,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 0
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},

api/api_autogen/library/defaults/Cashloan_FlatPlatePVCommercial.json

@@ -179,10 +179,6 @@
 		"Lifetime": {
 			"system_use_lifetime_output": 1
 		},
-		"ThirdPartyOwnership": {
-			"elec_cost_with_system": [0],
-			"elec_cost_without_system": [0]
-		},
 		"LCOS": {
 			"batt_salvage_percentage": 0
 		},