Skip to content

Commit ae93bbb

Browse files
committed
convert to float
1 parent 839649b commit ae93bbb

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

test/compare_elapsed_time.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ def get_feature_branch():
124124

125125

126126
def compare_time_elapsed(new_test_df, base_test_df, default_branch):
127-
diff_rel = os.getenv("DIFF_THRESHOLD_REL")
128-
diff_threshold = os.getenv("DIFF_THRESHOLD_MS")
127+
diff_rel = float(os.getenv("DIFF_THRESHOLD_REL"))
128+
diff_threshold = float(os.getenv("DIFF_THRESHOLD_MS"))
129129
feature_branch = get_feature_branch()
130130
compare_df = new_test_df.merge(base_test_df, how='outer', suffixes=[f" {feature_branch}", f" {default_branch}"], on=['Test Group', 'Test Name'])
131131

@@ -176,8 +176,12 @@ def compare_time_elapsed(new_test_df, base_test_df, default_branch):
176176
test_df = convert_log_to_csv(filename)
177177
else:
178178
test_df = pd.read_csv(filename)
179-
compare_time_elapsed(test_df, base_test_df, default_branch=base_branch)
179+
if compare_time_elapsed(test_df, base_test_df, default_branch=base_branch):
180+
sys.exit(0)
181+
else:
182+
sys.exit(1)
180183
else:
181184
raise RuntimeError("Options are 'gtest_log' or 'compare'. Use 'help' to see details")
182185

183186

187+

0 commit comments

Comments
 (0)