adjust linting rules and refactor methods to classmethods

Author: bnb32

pixi.lock

@@ -257,7 +257,7 @@ max-complexity = 12
 ]
 
 [tool.ruff.lint.pylint]
-max-args=12 # (PLR0913) Maximum number of arguments for function / method
+max-args=15 # (PLR0913) Maximum number of arguments for function / method
 max-bool-expr=5 # ( PLR0916) Boolean in a single if statement
 max-branches=12 # (PLR0912) branches allowed for a function or method body
 max-locals=15 # (PLR0912) local variables allowed for a function or method body

pyproject.toml

@@ -202,11 +202,13 @@ def __getattr__(self, attr):
             out = out[0]
         return out
 
-    def _getattr(self, dset, attr):
+    @classmethod
+    def _getattr(cls, dset, attr):
         """Get attribute from single data member."""
         return getattr(dset.sx, attr, getattr(dset, attr))
 
-    def _getitem(self, dset, item):
+    @classmethod
+    def _getitem(cls, dset, item):
         """Get item from single data member."""
         return dset.sx[item] if hasattr(dset, 'sx') else dset[item]
 

sup3r/preprocessing/base.py

@@ -14,7 +14,7 @@
     uniform_box_sampler,
     uniform_time_sampler,
 )
-from sup3r.preprocessing.utilities import compute_if_dask, lowered
+from sup3r.preprocessing.utilities import lowered
 
 logger = logging.getLogger(__name__)
 
@@ -29,7 +29,7 @@ def __init__(
         sample_shape: Optional[tuple] = None,
         batch_size: int = 16,
         feature_sets: Optional[dict] = None,
-        mode: str = 'lazy'
+        mode: str = 'lazy',
     ):
         """
         Parameters

sup3r/preprocessing/samplers/base.py

@@ -149,7 +149,7 @@ def reduce_high_res_sub_daily(self, high_res, csr_ind=0):
 
         *Needs review from @grantbuster
         """
-        if self.t_enhance not in (24, 1):
+        if self.t_enhance not in {24, 1}:
             high_res = self.get_middle_days(high_res, self.hr_sample_shape)
             high_res = nsrdb_reduce_daily_data(
                 high_res, self.hr_sample_shape[-1], csr_ind=csr_ind

sup3r/preprocessing/samplers/cc.py

@@ -346,9 +346,9 @@ def get_source_type(file_paths):
 
     _, source_type = os.path.splitext(file_paths[0])
 
-    if source_type in ('.h5', '.hdf'):
+    if source_type in {'.h5', '.hdf'}:
         return 'h5'
-    if source_type in ('.nc',):
+    if source_type in {'.nc'}:
         return 'nc'
     msg = (
         f'Can only handle HDF or NETCDF files. Received unknown extension '