Commit 44bf397
Prohibit limit_resources: false in Slurm mode and validate execution_config fields (#228)
* Omit --exact from srun when limit_resources is false
When limit_resources=false, srun was still passed --exact, which causes
it to default --cpus-per-task to 1. This silently restricted
multi-threaded jobs to a single CPU core via cgroups, causing significant
slowdowns (45%+ observed) compared to direct execution mode.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* SQLite synchronous and increased cache_size
* Increase max record transfer size from 10,000 to 100,000
Centralizes the limit as MAX_RECORD_TRANSFER_COUNT in lib.rs and updates
all server pagination, client batch creation, and API defaults to use it.
Also increases the default max request body size to 200 MiB to accommodate
larger payloads.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Prohibit limit_resources: false in Slurm mode
Slurm mode always requires resource limits for correct srun behavior.
Setting limit_resources: false with mode: slurm now returns a validation
error directing users to use direct mode instead. Removes the
limit_resources=false code paths from srun argument building and updates
documentation and tests accordingly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Validate execution_config fields against effective mode
Reject mode-incompatible fields at workflow creation time: direct-only
fields (termination_signal, sigterm_lead_seconds, oom_exit_code) error
in slurm mode, and slurm-only fields (srun_termination_signal,
enable_cpu_bind) error in direct mode. Auto mode infers from
slurm_schedulers presence. Restructures docs and struct comments to
group fields by shared/direct/slurm.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 884a13d commit 44bf397
File tree
29 files changed
+648
-332
lines changed- api
- docs/src
- core
- concepts
- reference
- workflows
- specialized
- design
- hpc
- julia_client
- Torc/src
- julia_client/docs
- python_client/src/torc
- slurm-tests
- tests
- workflows
- src
- bin
- client
- apis
- commands
- pagination
- server
- api
- tests
29 files changed
+648
-332
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3051 | 3051 | | |
3052 | 3052 | | |
3053 | 3053 | | |
3054 | | - | |
| 3054 | + | |
3055 | 3055 | | |
3056 | 3056 | | |
3057 | 3057 | | |
| |||
4169 | 4169 | | |
4170 | 4170 | | |
4171 | 4171 | | |
4172 | | - | |
| 4172 | + | |
4173 | 4173 | | |
4174 | 4174 | | |
4175 | 4175 | | |
| |||
6388 | 6388 | | |
6389 | 6389 | | |
6390 | 6390 | | |
6391 | | - | |
| 6391 | + | |
6392 | 6392 | | |
6393 | 6393 | | |
6394 | 6394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
| 172 | + | |
| 173 | + | |
173 | 174 | | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
183 | 178 | | |
184 | 179 | | |
185 | 180 | | |
186 | 181 | | |
187 | 182 | | |
188 | 183 | | |
189 | | - | |
190 | 184 | | |
191 | 185 | | |
192 | 186 | | |
| |||
215 | 209 | | |
216 | 210 | | |
217 | 211 | | |
218 | | - | |
| 212 | + | |
219 | 213 | | |
220 | 214 | | |
221 | 215 | | |
222 | | - | |
| 216 | + | |
223 | 217 | | |
224 | 218 | | |
225 | 219 | | |
226 | | - | |
| 220 | + | |
| 221 | + | |
227 | 222 | | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
| 223 | + | |
235 | 224 | | |
236 | | - | |
237 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
238 | 234 | | |
239 | 235 | | |
240 | 236 | | |
| |||
263 | 259 | | |
264 | 260 | | |
265 | 261 | | |
266 | | - | |
267 | 262 | | |
268 | 263 | | |
269 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | | - | |
| 453 | + | |
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
| |||
849 | 849 | | |
850 | 850 | | |
851 | 851 | | |
852 | | - | |
| 852 | + | |
853 | 853 | | |
854 | 854 | | |
855 | 855 | | |
| |||
898 | 898 | | |
899 | 899 | | |
900 | 900 | | |
901 | | - | |
| 901 | + | |
902 | 902 | | |
903 | 903 | | |
904 | 904 | | |
| |||
1030 | 1030 | | |
1031 | 1031 | | |
1032 | 1032 | | |
1033 | | - | |
| 1033 | + | |
1034 | 1034 | | |
1035 | 1035 | | |
1036 | 1036 | | |
| |||
1120 | 1120 | | |
1121 | 1121 | | |
1122 | 1122 | | |
1123 | | - | |
| 1123 | + | |
1124 | 1124 | | |
1125 | 1125 | | |
1126 | 1126 | | |
| |||
1135 | 1135 | | |
1136 | 1136 | | |
1137 | 1137 | | |
1138 | | - | |
| 1138 | + | |
1139 | 1139 | | |
1140 | 1140 | | |
1141 | 1141 | | |
| |||
1150 | 1150 | | |
1151 | 1151 | | |
1152 | 1152 | | |
1153 | | - | |
| 1153 | + | |
1154 | 1154 | | |
1155 | 1155 | | |
1156 | 1156 | | |
| |||
1200 | 1200 | | |
1201 | 1201 | | |
1202 | 1202 | | |
1203 | | - | |
| 1203 | + | |
1204 | 1204 | | |
1205 | 1205 | | |
1206 | 1206 | | |
| |||
1285 | 1285 | | |
1286 | 1286 | | |
1287 | 1287 | | |
1288 | | - | |
| 1288 | + | |
1289 | 1289 | | |
1290 | 1290 | | |
1291 | 1291 | | |
| |||
1357 | 1357 | | |
1358 | 1358 | | |
1359 | 1359 | | |
1360 | | - | |
| 1360 | + | |
1361 | 1361 | | |
1362 | 1362 | | |
1363 | 1363 | | |
| |||
1574 | 1574 | | |
1575 | 1575 | | |
1576 | 1576 | | |
1577 | | - | |
| 1577 | + | |
1578 | 1578 | | |
1579 | 1579 | | |
1580 | 1580 | | |
| |||
1930 | 1930 | | |
1931 | 1931 | | |
1932 | 1932 | | |
1933 | | - | |
| 1933 | + | |
1934 | 1934 | | |
1935 | 1935 | | |
1936 | 1936 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
191 | 211 | | |
192 | 212 | | |
193 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
| 296 | + | |
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
361 | | - | |
362 | 361 | | |
363 | 362 | | |
364 | 363 | | |
365 | 364 | | |
366 | 365 | | |
367 | 366 | | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
376 | 379 | | |
377 | 380 | | |
378 | 381 | | |
| |||
0 commit comments