Skip to content

Commit f7bd0f1

Browse files
authored
Merge pull request #214 from NatLabRockies/fix/refactor-direct-mode
Refactor direct mode
2 parents 357f759 + cd63e8a commit f7bd0f1

39 files changed

+5627
-645
lines changed

.claude/skills/review-api/SKILL.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,18 @@ Review new or modified API features for completeness and consistency.
5656
4. **Logging**: Check that log messages that include database record IDs use a format like
5757
`info!("Created workflow workflow_id={}", workflow_id);` so that parsing scripts pick them up.
5858

59+
### Performance
60+
61+
1. Review all changes for performance.
62+
2. Look for excessive invocations of CLI commands as subprocesses.
63+
3. Look for problematic API calls from client to the server. Batching is preferred where possible.
64+
4. Check SQL queries on the server for unnecessary joins.
65+
66+
### Code Quality
67+
68+
1. Check the changes for duplication and flag instances.
69+
2. Check functions for being too long and complicated.
70+
5971
## How to Review
6072

6173
1. Identify all files changed in the feature

.sqlx/query-08c034a4db847288ec6be9fb303a09aec1d2d73f2fa28e3dba1adaffe7eeecaf.json renamed to .sqlx/query-7dbd07f689e5e5f679beeb380eecf031816932da85d5be22cb48a86523ad37bc.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-a865c3ebec9e90753d7eb25a047d312da99a87f3feb9b1f8255cd9e764bb8b24.json renamed to .sqlx/query-98027bf568cee70d57b0c0564fcbabf1bcc1b1c46da6aae7df74fcf65dd1f6cd.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-d15599f7392d8005606247582f631c8ffa1b35c0ec3a670f90b7d74153449e09.json

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)