Unifying interface with rp2pio.StateMachine

[MiLaak]

Some of the pio_kwargs provided by adafruit_pioasm.Program() and used by rp2pio.StateMachine() needs to be renamed for pioemu.emulate().
Could pioemu be updated to use same kwargs?

For example in my test application, following modifications is needed to be done for pioemu.emulate():

program.pio_kwargs['side_set_count'] = program.pio_kwargs['sideset_pin_count']
program.pio_kwargs['wrap_top'] = program.pio_kwargs['wrap']

del program.pio_kwargs['sideset_enable']
del program.pio_kwargs['wrap']
del program.pio_kwargs['sideset_pin_count']

[NathanY3G]

Hi @MiLaak 👋

Thanks for the good suggestion - I can certainly see the advantage of aligning the names with CircuitPython (or MicroPython). Please note however, that some changes may still be required even if the names are aligned. For example, CircuitPython's wait_for_txstall is unlikely to be applicable so it would still need to be removed/commented-out if used. Would that match your expectations?

NB: If anybody else is reading this and has an opinion then please feel free to share it by adding a comment.

[MiLaak]

Hi @NathanY3G

Thanks for quick reply. Cool would be of course if there are separate pioemu.emulate() APIs for both CircuitPython and Micropython.

One pythonic way could be that HW related kwargs are just ignored by emulator? This way same kwargs could be used 1:1 for both hw and emulator. Emulator could also give warning message (which could be also suppressed) listing not supported kwargs?