Merge pull request #98 from Natifishman/feature/all-optimizations

Performance and Architecture Optimization

Author: Natifishman

.gitignore

@@ -93,3 +93,19 @@ app/server/src/main/resources/firebase-service-account.json
 /agents/agent_app_polish.md
 /agents/agent_improve_code.md
 /agents/agent_warnings_fix.md
+
+# Documentation and optimization files
+*.md
+!README.md
+!scripts/README.md
+/optimization/
+/.claude/
+CODE_REVIEW_CHECKLIST.md
+PR_INSTRUCTIONS.md
+COMMIT_STRATEGY.md
+ENTERPRISE_REFACTORING_FINAL_REPORT.md
+JAVA_INTEGRATION_CHANGES.md
+OPTIMIZATION_GUIDE.md
+PROJECT_CHANGES_SUMMARY.md
+UI_IMPROVEMENTS_ROADMAP.md
+XML_ENTERPRISE_REFACTORING_CHECKLIST.md

app/build.gradle.kts

@@ -308,6 +308,10 @@ dependencies {
     implementation(libs.google.firebase.storage)
     implementation(libs.firebase.firestore)
     // Note: Firebase Cloud Messaging intentionally excluded
+    
+    // Firebase App Check for security
+    implementation("com.google.firebase:firebase-appcheck-playintegrity:17.1.1")
+    implementation("com.google.firebase:firebase-appcheck-debug:17.1.1")
 
     // --- Google Services ---
     implementation(libs.gms.play.services.auth)

app/src/main/java/com/example/partymaker/PartyApplication.java

@@ -14,9 +14,13 @@
 import com.example.partymaker.data.repository.GroupRepository;
 import com.example.partymaker.data.repository.UserRepository;
 import com.example.partymaker.utils.infrastructure.system.MemoryManager;
+import com.example.partymaker.utils.infrastructure.PerformanceMonitor;
 import com.example.partymaker.ui.features.auxiliary.settings.ServerSettingsActivity;
 import com.example.partymaker.utils.ui.feedback.NotificationManager;
 import com.google.firebase.FirebaseApp;
+import com.google.firebase.appcheck.FirebaseAppCheck;
+import com.google.firebase.appcheck.playintegrity.PlayIntegrityAppCheckProviderFactory;
+import com.google.firebase.appcheck.debug.DebugAppCheckProviderFactory;
 
 /** Application class for PartyMaker. Initializes repositories and other app-wide components. */
 public class PartyApplication extends Application {
@@ -28,18 +32,27 @@ public void onCreate() {
     super.onCreate();
     instance = this;
 
+    // Start performance monitoring
+    PerformanceMonitor.startTiming("Application.onCreate");
+    PerformanceMonitor.trackMemoryUsage("Application.onCreate.start");
+
     // Apply saved theme preference
     ServerSettingsActivity.applyThemeFromPreferences(this);
     Log.d(TAG, "Theme preference applied");
 
     // Initialize Firebase
     try {
+      PerformanceMonitor.startTiming("Firebase.init");
       FirebaseApp.initializeApp(this);
       Log.d(TAG, "Firebase initialized successfully");
+      
+      // Initialize Firebase App Check for security
+      initializeAppCheck();
 
       // Initialize Firebase references
       DBRef.init();
       Log.d(TAG, "Firebase references initialized successfully");
+      PerformanceMonitor.endTiming("Firebase.init");
     } catch (Exception e) {
       Log.e(TAG, "Error initializing Firebase", e);
     }
@@ -80,6 +93,10 @@ public void onCreate() {
     // Log memory info
     Log.d(TAG, "Initial memory usage: " + MemoryManager.getDetailedMemoryInfo());
 
+    // End application initialization timing
+    PerformanceMonitor.trackMemoryUsage("Application.onCreate.end");
+    PerformanceMonitor.endTiming("Application.onCreate");
+    
     Log.d(TAG, "Application initialized");
   }
 
@@ -128,6 +145,33 @@ public void onTerminate() {
   public static PartyApplication getInstance() {
     return instance;
   }
+  
+  /**
+   * Initializes Firebase App Check for enhanced security.
+   * Uses Play Integrity for production and Debug provider for testing.
+   */
+  private void initializeAppCheck() {
+    try {
+      FirebaseAppCheck firebaseAppCheck = FirebaseAppCheck.getInstance();
+      
+      if (BuildConfig.DEBUG) {
+        // Use debug provider for testing
+        Log.d(TAG, "Initializing App Check with Debug provider");
+        firebaseAppCheck.installAppCheckProviderFactory(
+            DebugAppCheckProviderFactory.getInstance());
+      } else {
+        // Use Play Integrity for production
+        Log.d(TAG, "Initializing App Check with Play Integrity provider");
+        firebaseAppCheck.installAppCheckProviderFactory(
+            PlayIntegrityAppCheckProviderFactory.getInstance());
+      }
+      
+      Log.d(TAG, "Firebase App Check initialized successfully");
+    } catch (Exception e) {
+      Log.e(TAG, "Failed to initialize App Check - continuing without it", e);
+      // App can still function without App Check, but with reduced security
+    }
+  }
 
   /**
    * Sets up memory monitoring for debug builds.

app/src/main/java/com/example/partymaker/data/local/AppDatabase.java

@@ -65,6 +65,9 @@ public void onCreate(@NonNull SupportSQLiteDatabase db) {
           super.onCreate(db);
           Log.i(TAG, "Database created for the first time");
           createCustomIndexes(db);
+          
+          // Database monitoring is done through static methods
+          // No initialization needed for DatabaseMonitor
         }
 
         @Override
@@ -74,6 +77,9 @@ public void onOpen(@NonNull SupportSQLiteDatabase db) {
 
           enableForeignKeys(db);
           optimizeDatabasePerformance(db);
+          
+          // Log database opening
+          Log.d(TAG, "Database opened successfully");
         }
 
         @Override

app/src/main/java/com/example/partymaker/ui/features/core/MainActivity.java

@@ -94,6 +94,20 @@ public class MainActivity extends BaseActivity {
   private String currentSortMode = "date_nearest"; // default sort
   private boolean filterPublicOnly = false;
   private boolean filterPrivateOnly = false;
+  
+  // Date format patterns for parsing
+  private static final java.text.SimpleDateFormat[] DATE_FORMATS = {
+      new java.text.SimpleDateFormat("dd/MM/yyyy", java.util.Locale.getDefault()),
+      new java.text.SimpleDateFormat("d/MM/yyyy", java.util.Locale.getDefault()),
+      new java.text.SimpleDateFormat("dd/M/yyyy", java.util.Locale.getDefault()),
+      new java.text.SimpleDateFormat("d/M/yyyy", java.util.Locale.getDefault()),
+      new java.text.SimpleDateFormat("dd/MMMM/yyyy", java.util.Locale.ENGLISH),
+      new java.text.SimpleDateFormat("d/MMMM/yyyy", java.util.Locale.ENGLISH),
+      new java.text.SimpleDateFormat("dd/MMM/yyyy", java.util.Locale.ENGLISH),
+      new java.text.SimpleDateFormat("d/MMM/yyyy", java.util.Locale.ENGLISH)
+  };
+
+ 
   private boolean filterFreeOnly = false;
   private boolean filterUpcomingOnly = false;
 
@@ -821,22 +835,57 @@ private List<Group> sortGroups(List<Group> groups) {
 
   private int compareDates(Group g1, Group g2) {
     try {
+      // Check for null values first
+      if (g1.getGroupDays() == null || g1.getGroupMonths() == null || g1.getGroupYears() == null ||
+          g2.getGroupDays() == null || g2.getGroupMonths() == null || g2.getGroupYears() == null) {
+        return 0;
+      }
+      
       String date1 = g1.getGroupDays() + "/" + g1.getGroupMonths() + "/" + g1.getGroupYears();
       String date2 = g2.getGroupDays() + "/" + g2.getGroupMonths() + "/" + g2.getGroupYears();
 
-      java.text.SimpleDateFormat sdf = new java.text.SimpleDateFormat("dd/MM/yyyy", java.util.Locale.getDefault());
-      java.util.Date d1 = sdf.parse(date1);
-      java.util.Date d2 = sdf.parse(date2);
-      
-      if (d1 != null && d2 != null) {
-        return d1.compareTo(d2);
+      // Check for "null" strings
+      if (date1.contains("null") || date2.contains("null")) {
+        return 0;
       }
+      
+      java.util.Date d1 = parseDate(date1);
+      java.util.Date d2 = parseDate(date2);
+      
+      if (d1 == null && d2 == null) return 0;
+      if (d1 == null) return 1;
+      if (d2 == null) return -1;
+      
+      return d1.compareTo(d2);
     } catch (Exception e) {
       Log.w(TAG, "Error comparing dates", e);
     }
     return 0;
   }
 
+  /**
+   * Parse date string with multiple format support
+   */
+  private java.util.Date parseDate(String dateStr) {
+    if (dateStr == null || dateStr.isEmpty() || dateStr.contains("null")) {
+      return null;
+    }
+    
+    // Try each date format
+    for (java.text.SimpleDateFormat format : DATE_FORMATS) {
+      try {
+        format.setLenient(false);
+        return format.parse(dateStr);
+      } catch (java.text.ParseException e) {
+        // Try next format
+      }
+    }
+    
+    // Log error only once for unparseable dates
+    Log.w(TAG, "Could not parse date: " + dateStr);
+    return null;
+  }
+  
   private void showSortFilterDialog() {
     android.app.AlertDialog.Builder builder = new android.app.AlertDialog.Builder(this);
     View dialogView = getLayoutInflater().inflate(R.layout.dialog_sort_filter, null);