Skip to content

Commit 152e5a4

Browse files
authored
Merge pull request #32 from NativePHP/fix/intel-mac-native-run-php-binary
Fix `narive:run` use correct binary on Intel macs
2 parents cf0e000 + 6aa3beb commit 152e5a4

File tree

6 files changed

+382
-354
lines changed

6 files changed

+382
-354
lines changed

resources/electron/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121
"publish:win-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p always --win --config electron-builder.mjs --x64",
2222
"publish:mac": "cross-env npm run publish:mac-arm64 -- --x64",
2323
"publish:mac-arm64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p always --mac --config electron-builder.mjs --arm64 -p always",
24-
"publish:mac-x86": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p always --mac --config electron-builder.mjs --x64 -p always",
24+
"publish:mac-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p always --mac --config electron-builder.mjs --x64 -p always",
2525
"publish:linux": "cross-env npm run publish:linux-x64",
2626
"publish:linux-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js --linux --config electron-builder.mjs --x64 -p always",
2727
"build:all": "cross-env npm run build:mac && cross-env npm run build:win && cross-env npm run build:linux",
2828
"build:win": "cross-env npm run build:win-x64",
2929
"build:win-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p never --win --config electron-builder.mjs --x64",
3030
"build:mac": "cross-env npm run build:mac-arm64 -- --x64",
3131
"build:mac-arm64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p never --mac --config electron-builder.mjs --arm64",
32-
"build:mac-x86": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p never --mac --config electron-builder.mjs --x64",
32+
"build:mac-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p never --mac --config electron-builder.mjs --x64",
3333
"build:linux": "cross-env npm run build:linux-x64",
3434
"build:linux-x64": "cross-env npm run build && cross-env node ./node_modules/electron-builder/cli.js -p never --linux --config electron-builder.mjs --x64",
3535
"plugin:build": "rimraf electron-plugin/dist/ && node node_modules/typescript/bin/tsc --project electron-plugin",

resources/electron/php.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ const platform = {
2424

2525
if (isWindows) {
2626
platform.os = 'win';
27-
platform.phpBinary += '.exe';
2827
platform.arch = 'x64';
28+
platform.phpBinary += '.exe';
2929
}
3030

3131
if (isLinux) {
@@ -35,7 +35,7 @@ if (isLinux) {
3535

3636
if (isDarwin) {
3737
platform.os = 'mac';
38-
platform.arch = 'x86';
38+
platform.arch = 'x64';
3939
}
4040

4141
if (isArm64) {
@@ -46,7 +46,6 @@ if (isArm64) {
4646
if (isBuilding) {
4747
// Only one will be used by the configured build commands in package.json
4848
platform.arch = process.argv.includes('--x64') ? 'x64' : platform.arch;
49-
platform.arch = process.argv.includes('--x86') ? 'x86' : platform.arch;
5049
platform.arch = process.argv.includes('--arm64') ? 'arm64' : platform.arch;
5150
}
5251

@@ -65,6 +64,9 @@ if (platform.phpBinary) {
6564

6665
ensureDirSync(binaryDestDir);
6766

67+
console.log('FOOOOO')
68+
console.dir(binarySrcDir);
69+
6870
// Unzip the files
6971
unzip.open(binarySrcDir, {lazyEntries: true}, function (err, zipfile) {
7072
if (err) throw err;

0 commit comments

Comments
 (0)