Only set the dock icon on macOS

mpociot · mpociot · commit 6d9ed2538895 · 2023-07-25T17:36:00.000+02:00
diff --git a/dist/index.js b/dist/index.js
@@ -75,7 +75,7 @@ class NativePHP {
     bootstrapApp(app) {
         app.whenReady().then(() => __awaiter(this, void 0, void 0, function* () {
             var _a;
-            if (process.env.NODE_ENV === 'development') {
+            if (process.platform === 'darwin' && process.env.NODE_ENV === 'development') {
                 app.dock.setIcon(state_1.default.icon);
             }
             app.on('browser-window-created', (_, window) => {
diff --git a/src/index.ts b/src/index.ts
@@ -77,7 +77,8 @@ class NativePHP {
   private bootstrapApp(app: Electron.CrossProcessExports.App) {
     app.whenReady().then(async () => {
 
-      if (process.env.NODE_ENV === 'development') {
+      // Only run this on macOS
+      if (process.platform === 'darwin' && process.env.NODE_ENV === 'development') {
         app.dock.setIcon(state.icon)
       }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class NativePHP {`
`75`	`75`	`bootstrapApp(app) {`
`76`	`76`	`app.whenReady().then(() => __awaiter(this, void 0, void 0, function* () {`
`77`	`77`	`var _a;`
`78`		`- if (process.env.NODE_ENV === 'development') {`
	`78`	`+ if (process.platform === 'darwin' && process.env.NODE_ENV === 'development') {`
`79`	`79`	`app.dock.setIcon(state_1.default.icon);`
`80`	`80`	`}`
`81`	`81`	`app.on('browser-window-created', (_, window) => {`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ class NativePHP {`
`77`	`77`	`private bootstrapApp(app: Electron.CrossProcessExports.App) {`
`78`	`78`	`app.whenReady().then(async () => {`
`79`	`79`
`80`		`- if (process.env.NODE_ENV === 'development') {`
	`80`	`+ // Only run this on macOS`
	`81`	`+ if (process.platform === 'darwin' && process.env.NODE_ENV === 'development') {`
`81`	`82`	`app.dock.setIcon(state.icon)`
`82`	`83`	`}`
`83`	`84`