remove unnecessary space escape

Author: gwleuverink

src/ChildProcess.php

@@ -12,11 +12,10 @@ public function start(string|array $cmd, string $alias, ?string $cwd = null, ?ar
     {
         $cwd = $cwd ?? base_path();
 
-        $cmd = is_iterable($cmd)
-            // when an array is passed, escape spaces for each item
-            ? array_map(fn ($a) => str_replace(' ', '\ ', $a), $cmd)
-            // when a string is passed, explode it on the space
-            : array_values(array_filter(explode(' ', $cmd)));
+        if (is_string($cmd)) {
+            // When a string is passed, explode it on the space
+            $cmd = array_values(array_filter(explode(' ', $cmd)));
+        }
 
         $this->client->post('child-process/start', [
             'alias' => $alias,

tests/ChildProcess/ChildProcessTest.php

@@ -26,7 +26,7 @@
     Http::assertSent(function (Request $request) {
         return $request->url() === 'http://localhost:4000/api/child-process/start' &&
                $request['alias'] === 'some-alias' &&
-               $request['cmd'] === [str_replace(' ', '\ ', PHP_BINARY), 'artisan', 'foo:bar'] &&
+               $request['cmd'] === [PHP_BINARY, 'artisan', 'foo:bar'] &&
                $request['cwd'] === base_path() &&
                $request['env'] === ['baz' => 'zah'];
     });
@@ -44,10 +44,10 @@
 
 it('accepts either a string or a array as artisan command argument', function () {
     ChildProcess::artisan('foo:bar', 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === [str_replace(' ', '\ ', PHP_BINARY), 'artisan', 'foo:bar']);
+    Http::assertSent(fn (Request $request) => $request['cmd'] === [PHP_BINARY, 'artisan', 'foo:bar']);
 
     ChildProcess::artisan(['foo:baz'], 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === [str_replace(' ', '\ ', PHP_BINARY), 'artisan', 'foo:baz']);
+    Http::assertSent(fn (Request $request) => $request['cmd'] === [PHP_BINARY, 'artisan', 'foo:baz']);
 });
 
 it('sets the cwd to the base path if none was given', function () {
@@ -63,11 +63,6 @@
     Http::assertSent(fn (Request $request) => $request['cmd'] === ['foo', 'bar', 'baz', 'bak']);
 });
 
-it('escapes spaces when passing a command array', function () {
-    ChildProcess::start(['path/to/some executable with spaces.sh', '--foo', '--bar'], 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === ['path/to/some\ executable\ with\ spaces.sh', '--foo', '--bar']);
-});
-
 it('can stop a child process', function () {
     ChildProcess::stop('some-alias');