remove exploding string commands

Author: gwleuverink

src/ChildProcess.php

@@ -61,7 +61,7 @@ public function start(
 
         $process = $this->client->post('child-process/start', [
             'alias' => $alias,
-            'cmd' => $this->explodeCommand($cmd),
+            'cmd' => (array) $cmd,
             'cwd' => $cwd ?? base_path(),
             'env' => $env,
             'persistent' => $persistent,
@@ -72,14 +72,14 @@ public function start(
 
     public function php(string|array $cmd, string $alias, ?array $env = null, ?bool $persistent = false): self
     {
-        $cmd = [PHP_BINARY, ...$this->explodeCommand($cmd)];
+        $cmd = [PHP_BINARY, ...(array) $cmd];
 
         return $this->start($cmd, $alias, env: $env, persistent: $persistent);
     }
 
     public function artisan(string|array $cmd, string $alias, ?array $env = null, ?bool $persistent = false): self
     {
-        $cmd = ['artisan', ...$this->explodeCommand($cmd)];
+        $cmd = ['artisan', ...(array) $cmd];
 
         return $this->php($cmd, $alias, env: $env, persistent: $persistent);
     }
@@ -126,13 +126,4 @@ protected function fromRuntimeProcess($process): static
 
         return $this;
     }
-
-    private function explodeCommand(string|array $cmd): array
-    {
-        if (is_iterable($cmd)) {
-            return $cmd;
-        }
-
-        return array_values(array_filter(explode(' ', $cmd)));
-    }
 }

tests/ChildProcess/ChildProcessTest.php

@@ -25,7 +25,7 @@
     Http::assertSent(function (Request $request) {
         return $request->url() === 'http://localhost:4000/api/child-process/start' &&
                $request['alias'] === 'some-alias' &&
-               $request['cmd'] === ['foo', 'bar'] &&
+               $request['cmd'] === ['foo bar'] &&
                $request['cwd'] === 'path/to/dir' &&
                $request['env'] === ['baz' => 'zah'];
     });
@@ -37,7 +37,7 @@
     Http::assertSent(function (Request $request) {
         return $request->url() === 'http://localhost:4000/api/child-process/start' &&
                $request['alias'] === 'some-alias' &&
-               $request['cmd'] === [PHP_BINARY, '-r', "'sleep(5);'"] &&
+               $request['cmd'] === [PHP_BINARY, "-r 'sleep(5);'"] &&
                $request['cwd'] === base_path() &&
                $request['env'] === ['baz' => 'zah'];
     });
@@ -49,25 +49,25 @@
     Http::assertSent(function (Request $request) {
         return $request->url() === 'http://localhost:4000/api/child-process/start' &&
                $request['alias'] === 'some-alias' &&
-               $request['cmd'] === [PHP_BINARY, 'artisan', 'foo:bar', '--verbose'] &&
+               $request['cmd'] === [PHP_BINARY, 'artisan', 'foo:bar --verbose'] &&
                $request['cwd'] === base_path() &&
                $request['env'] === ['baz' => 'zah'];
     });
 });
 
 it('accepts either a string or a array as start command argument', function () {
     ChildProcess::start('foo bar', 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === ['foo', 'bar']);
+    Http::assertSent(fn (Request $request) => $request['cmd'] === ['foo bar']);
 
     ChildProcess::start(['foo', 'baz'], 'some-alias');
     Http::assertSent(fn (Request $request) => $request['cmd'] === ['foo', 'baz']);
 });
 
 it('accepts either a string or a array as php command argument', function () {
     ChildProcess::php("-r 'sleep(5);'", 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === [PHP_BINARY, '-r', "'sleep(5);'"]);
+    Http::assertSent(fn (Request $request) => $request['cmd'] === [PHP_BINARY, "-r 'sleep(5);'"]);
 
-    ChildProcess::artisan(['-r', "'sleep(5);'"], 'some-alias');
+    ChildProcess::php(['-r', "'sleep(5);'"], 'some-alias');
     Http::assertSent(fn (Request $request) => $request['cmd'] === [PHP_BINARY, '-r', "'sleep(5);'"]);
 });
 
@@ -87,11 +87,6 @@
     Http::assertSent(fn (Request $request) => $request['cwd'] === base_path());
 });
 
-it('filters double spaces when exploding a command string', function () {
-    ChildProcess::start('foo bar  baz      bak', 'some-alias');
-    Http::assertSent(fn (Request $request) => $request['cmd'] === ['foo', 'bar', 'baz', 'bak']);
-});
-
 it('can stop a child process', function () {
     ChildProcess::stop('some-alias');