Added has method to Settings class
#563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajmeireles
changed the title
Settings classhas method to Settings class
SRWieZ
approved these changes
Apr 23, 2025
SRWieZ
requested changes
Apr 23, 2025
Member
SRWieZ
left a comment
SRWieZ
left a comment
There was a problem hiding this comment.
It would make more sense to have an has endpoint on the electron part otherwise I don't see the benefit.
Member
|
Not sure we need all the type hints in docblocks when we have type hints in code... let's not duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a method called
hasthat can be used to check if a given configuration is set.This is similar to get, the difference is that we apply a
!== nullto the obtained value.