fix: use cashier subscription_item_id fk, not stripe subscription item id

Author: steven-fox

app/Jobs/HandleCustomerSubscriptionCreatedJob.php

@@ -10,6 +10,7 @@
 use Illuminate\Queue\SerializesModels;
 use Laravel\Cashier\Cashier;
 use Laravel\Cashier\Events\WebhookHandled;
+use Laravel\Cashier\SubscriptionItem;
 use Stripe\Subscription;
 
 class HandleCustomerSubscriptionCreatedJob implements ShouldQueue
@@ -38,7 +39,10 @@ public function handle(): void
         }
 
         $subscriptionPlan = \App\Enums\Subscription::fromStripeSubscription($stripeSubscription);
-        $subscriptionItemId = $stripeSubscription->items->first()->id;
+        $cashierSubscriptionItemId = SubscriptionItem::query()
+            ->where('stripe_id', $stripeSubscription->items->first()->id)
+            ->first()
+            ->id;
 
         $nameParts = explode(' ', $user->name ?? '', 2);
         $firstName = $nameParts[0] ?: null;
@@ -47,7 +51,7 @@ public function handle(): void
         dispatch(new CreateAnystackLicenseJob(
             $user,
             $subscriptionPlan,
-            $subscriptionItemId,
+            $cashierSubscriptionItemId,
             $firstName,
             $lastName,
         ));

tests/Feature/Jobs/HandleCustomerSubscriptionCreatedJobTest.php

@@ -21,15 +21,7 @@ class HandleCustomerSubscriptionCreatedJobTest extends TestCase
     /** @test */
     public function it_dispatches_the_create_anystack_license_job_with_correct_data()
     {
-        $mockCustomer = Customer::constructFrom([
-            'id' => 'cus_S9dhoV2rJK2Auy',
-            'email' => '[email protected]',
-            'name' => 'John Doe',
-        ]);
-
-        $this->mockStripeClient($mockCustomer);
-
-        dispatch_sync(new CreateUserFromStripeCustomer($mockCustomer));
+        $this->createTestData('John Doe');
 
         Bus::fake();
 
@@ -54,15 +46,7 @@ public function it_dispatches_the_create_anystack_license_job_with_correct_data(
      */
     public function it_extracts_customer_name_parts_correctly($fullName, $expectedFirstName, $expectedLastName)
     {
-        $mockCustomer = Customer::constructFrom([
-            'id' => 'cus_S9dhoV2rJK2Auy',
-            'email' => '[email protected]',
-            'name' => $fullName,
-        ]);
-
-        $this->mockStripeClient($mockCustomer);
-
-        dispatch_sync(new CreateUserFromStripeCustomer($mockCustomer));
+        $this->createTestData($fullName);
 
         $webhookCall = new WebhookHandled($this->getTestWebhookPayload());
 
@@ -117,6 +101,37 @@ public function it_fails_when_customer_has_no_email()
         Bus::assertNotDispatched(CreateAnystackLicenseJob::class);
     }
 
+    protected function createTestData(?string $customerName)
+    {
+        $mockCustomer = Customer::constructFrom([
+            'id' => $this->getTestWebhookPayload()['data']['object']['customer'],
+            'email' => $email = '[email protected]',
+            'name' => $customerName,
+        ]);
+
+        $this->mockStripeClient($mockCustomer);
+
+        dispatch_sync(new CreateUserFromStripeCustomer($mockCustomer));
+
+        $user = User::query()->where('email', $email)->firstOrFail();
+
+        $subscription = \Laravel\Cashier\Subscription::factory()
+            ->for($user, 'user')
+            ->create([
+                'stripe_id' => $this->getTestWebhookPayload()['data']['object']['id'],
+                'stripe_status' => 'active',
+                'stripe_price' => $this->getTestWebhookPayload()['data']['object']['items']['data'][0]['price']['id'],
+                'quantity' => 1,
+            ]);
+        $subscriptionItem = \Laravel\Cashier\SubscriptionItem::factory()
+            ->for($subscription, 'subscription')
+            ->create([
+                'stripe_id' => $this->getTestWebhookPayload()['data']['object']['items']['data'][0]['id'],
+                'stripe_price' => $this->getTestWebhookPayload()['data']['object']['items']['data'][0]['price']['id'],
+                'quantity' => 1,
+            ]);
+    }
+
     protected function getTestWebhookPayload(): array
     {
         return [