Skip to content

Make every external link has target blank #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

codingwithrk
Copy link

Change:

  1. This PR updates all external links to include target="_blank" so they open in a new browser tab.
  2. In config/filament.php file str_getcsv are deprecated in PHP v8.4.0 Here the Ref

Reason:
Opening external links in a new tab improves user experience by preventing users from unintentionally navigating away from our site. This is especially useful when linking to third-party resources, documentation, or external tools.

Implementation Details:

  • Identified external links
  • Ensured all such links now include target="_blank"
  • Verified that internal links remain unaffected

Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str_getcsv is not deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants