Merge pull request #819 from NativeScript/pete/fix-gc-crash

Fix v8 GC Crash caused by incorrect usage of the internal V8 API

Author: petekanev

runtime/src/main/jni/ObjectManager.cpp

@@ -109,7 +109,7 @@ ObjectManager::JSInstanceInfo* ObjectManager::GetJSInstanceInfo(const Local<Obje
 }
 
 bool ObjectManager::IsJsRuntimeObject(const v8::Local<v8::Object>& object) {
-    int internalFieldCount = NativeScriptExtension::GetInternalFieldCount(object);
+    int internalFieldCount = object->InternalFieldCount();
     const int count = static_cast<int>(MetadataNodeKeys::END);
     return internalFieldCount == count;
 }

runtime/src/main/jni/include/V8NativeScriptExtension.h

@@ -14,6 +14,10 @@ namespace v8 {
 
 		static v8::Local<v8::Array> GetPropertyKeys(v8::Isolate *isolate, const v8::Local<v8::Context>& context, const v8::Local<v8::Object>& object, bool& success);
 
+		/*
+		 * Deprecated. Use V8 Object.InternalFieldCount() instead.
+		 * TODO: Pete: remove in following 6.x update
+		 */
 		static int GetInternalFieldCount(const v8::Local<v8::Object>& object);
 
         static void CpuFeaturesProbe(bool cross_compile);