Skip to content

Commit 8c389e2

Browse files
committed
clean up some of the redundant logs output when __enableVerboseLogging was used
1 parent e683d82 commit 8c389e2

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

runtime/src/main/jni/CallbackHandlers.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ bool CallbackHandlers::RegisterInstance(Isolate* isolate, const Local<Object>& j
8989

9090
int javaObjectID = objectManager->GenerateNewObjectID();
9191

92-
DEBUG_WRITE("RegisterInstance: Linking new instance");
9392
objectManager->Link(jsObject, javaObjectID, nullptr);
9493

9594
// resolve constructor
@@ -122,11 +121,10 @@ bool CallbackHandlers::RegisterInstance(Isolate* isolate, const Local<Object>& j
122121
success = !localInstance.IsNull();
123122

124123
if (success) {
125-
DEBUG_WRITE("RegisterInstance: Updating linked instance with its real class");
126124
jclass instanceClass = env.FindClass(fullClassName);
127125
objectManager->SetJavaClass(jsObject, instanceClass);
128126
} else {
129-
DEBUG_WRITE("RegisterInstance failed with null new instance");
127+
DEBUG_WRITE_FORCE("RegisterInstance failed with null new instance class: %s", fullClassName.c_str());
130128
}
131129

132130
return success;
@@ -775,8 +773,6 @@ Local<Value> CallbackHandlers::CallJSMethod(Isolate* isolate, JNIEnv* _env,
775773
arguments[i] = jsArgs->Get(i);
776774
}
777775

778-
DEBUG_WRITE("implementationObject->GetIdentityHash()=%d", jsObject->GetIdentityHash());
779-
780776
TryCatch tc;
781777
Local<Value> jsResult;
782778
{

runtime/src/main/jni/ObjectManager.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ JniLocalRef ObjectManager::GetJavaObjectByJsObject(const Local<Object>& object)
7979
}
8080

8181
ObjectManager::JSInstanceInfo* ObjectManager::GetJSInstanceInfo(const Local<Object>& object) {
82-
DEBUG_WRITE("ObjectManager::GetJSInstanceInfo: called");
8382
JSInstanceInfo* jsInstanceInfo = nullptr;
8483

8584
auto isolate = m_isolate;
@@ -140,8 +139,6 @@ jclass ObjectManager::GetJavaClass(const Local<Object>& instance) {
140139
}
141140

142141
void ObjectManager::SetJavaClass(const Local<Object>& instance, jclass clazz) {
143-
DEBUG_WRITE("SetClass called");
144-
145142
JSInstanceInfo* jsInfo = GetJSInstanceInfo(instance);
146143
jsInfo->ObjectClazz = clazz;
147144
}
@@ -275,8 +272,6 @@ void ObjectManager::JSObjectWeakCallbackStatic(const WeakCallbackInfo<ObjectWeak
275272
* These objects are categorized by "regular" and "callback" and saved in different arrays for performance optimizations during GC
276273
* */
277274
void ObjectManager::JSObjectWeakCallback(Isolate* isolate, ObjectWeakCallbackState* callbackState) {
278-
DEBUG_WRITE("JSObjectWeakCallback called");
279-
280275
HandleScope handleScope(isolate);
281276

282277
Persistent<Object>* po = callbackState->target;
@@ -319,8 +314,6 @@ int ObjectManager::GenerateNewObjectID() {
319314
}
320315

321316
void ObjectManager::ReleaseJSInstance(Persistent<Object>* po, JSInstanceInfo* jsInstanceInfo) {
322-
DEBUG_WRITE("ReleaseJSInstance instance");
323-
324317
int javaObjectID = jsInstanceInfo->JavaObjectID;
325318

326319
auto it = m_idToObject.find(javaObjectID);
@@ -522,7 +515,7 @@ void ObjectManager::MarkReachableObjects(Isolate* isolate, const Local<Object>&
522515
} // while
523516
}
524517

525-
void ObjectManager::MarkReachableArrayElements(Local<Object> &o, stack<Local<Value>> &s) {
518+
void ObjectManager::MarkReachableArrayElements(Local<Object>& o, stack<Local<Value>>& s) {
526519
auto arr = o.As<Array>();
527520

528521
int arrEnclosedObjectsLength = arr->Length();

0 commit comments

Comments
 (0)