Skip to content

Commit 98970ae

Browse files
committed
fix: pass propName as const to GetChildMetadataForPackage
1 parent 10bd6a2 commit 98970ae

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test-app/runtime/src/main/cpp/MetadataNode.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1802,7 +1802,7 @@ MetadataNode* MetadataNode::GetNodeFromHandle(const Local<Object>& value) {
18021802
return node;
18031803
}
18041804

1805-
MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, std::string propName) {
1805+
MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, const std::string &propName) {
18061806
assert(node->m_treeNode->children != nullptr);
18071807

18081808
MetadataEntry child(nullptr, NodeType::Class);

test-app/runtime/src/main/cpp/MetadataNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class MetadataNode {
121121

122122
static MetadataTreeNode* GetOrCreateTreeNodeByName(const std::string& className);
123123

124-
static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, std::string propName);
124+
static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, const std::string &propName);
125125

126126
static MetadataNode* GetInstanceMetadata(v8::Isolate* isolate, const v8::Local<v8::Object>& value);
127127

0 commit comments

Comments
 (0)