Merge pull request #1222 from NativeScript/kddimitrov/fix-cyclic-task-dependency-error-with-firebase-plugin

vtrifonov · web-flow · commit adf4c2d999e7 · 2018-12-03T16:05:44.000+02:00
fix: cyclic task dependency with nativescript-plugin-firebase plugin
diff --git a/test-app/app/build.gradle b/test-app/app/build.gradle
@@ -369,7 +369,7 @@ tasks.whenTaskAdded({ org.gradle.api.DefaultTask currentTask ->
         ensureMetadataOutDir.finalizedBy(buildMetadata)
     }
     if (currentTask =~ /merge.*Assets/) {
-        currentTask.dependsOn(buildMetadata);
+        currentTask.shouldRunAfter(buildMetadata);
     }
     if (currentTask =~ /assemble.*Debug/ || currentTask =~ /assemble.*Release/) {
         currentTask.finalizedBy("validateAppIdMatch")

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ tasks.whenTaskAdded({ org.gradle.api.DefaultTask currentTask ->`
`369`	`369`	`ensureMetadataOutDir.finalizedBy(buildMetadata)`
`370`	`370`	`}`
`371`	`371`	`if (currentTask =~ /merge.*Assets/) {`
`372`		`- currentTask.dependsOn(buildMetadata);`
	`372`	`+ currentTask.shouldRunAfter(buildMetadata);`
`373`	`373`	`}`
`374`	`374`	`if (currentTask =~ /assemble.Debug/ \|\| currentTask =~ /assemble.Release/) {`
`375`	`375`	`currentTask.finalizedBy("validateAppIdMatch")`