Skip to content

Commit bbbc8b0

Browse files
committed
fix(dts-gen): call task for dts generation when parameter is passed
1 parent 6af48b4 commit bbbc8b0

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

test-app/app/build.gradle

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ def MDG_OUTPUT_DIR = "mdg-output-dir.txt"
4343
def MDG_JAVA_DEPENDENCIES = "mdg-java-dependencies.txt"
4444
def METADATA_OUT_PATH = "$projectDir/src/main/assets/metadata"
4545

46-
//paths to jar libraries
47-
def jarLibraries = new LinkedList<String>()
46+
// paths to jar libraries
47+
def pluginsJarLibraries = new LinkedList<String>()
48+
def allJarLibraries = new LinkedList<String>()
4849

4950
// the build script will not work with previous versions of the CLI (3.1 or earlier)
5051
def dependenciesJson = file("$rootDir/dependencies.json")
@@ -235,7 +236,7 @@ task addDependenciesFromNativeScriptPlugins {
235236
jarFiles.each { jarFile ->
236237
def jarFileAbsolutePath = jarFile.getAbsolutePath()
237238
println "\t + adding jar plugin dependency: $jarFileAbsolutePath"
238-
jarLibraries.add(jarFile.getAbsolutePath())
239+
pluginsJarLibraries.add(jarFile.getAbsolutePath())
239240
}
240241

241242
project.dependencies.add("implementation", jarFiles)
@@ -258,7 +259,7 @@ task addDependenciesFromAppResourcesLibraries {
258259
jarFiles.each { jarFile ->
259260
def jarFileAbsolutePath = jarFile.getAbsolutePath()
260261
println "\t + adding jar plugin dependency: $jarFileAbsolutePath"
261-
jarLibraries.add(jarFile.getAbsolutePath())
262+
pluginsJarLibraries.add(jarFile.getAbsolutePath())
262263
}
263264

264265
project.dependencies.add("compile", jarFiles)
@@ -360,7 +361,7 @@ task collectAllJars {
360361
doFirst {
361362
def allJarPaths = new LinkedList<String>()
362363
allJarPaths.add(androidJar)
363-
allJarPaths.addAll(jarLibraries)
364+
allJarPaths.addAll(pluginsJarLibraries)
364365
def ft = fileTree(dir: extractedDependenciesDir, include: "**/*.jar")
365366
ft.each { currentJarFile ->
366367
allJarPaths.add(currentJarFile.getAbsolutePath())
@@ -383,6 +384,8 @@ task collectAllJars {
383384
new File("$BUILD_TOOLS_PATH/$SBG_OUTPUT_FILE").withWriter { out ->
384385
out.println OUTPUT_JAVA_DIR
385386
}
387+
388+
allJarLibraries.addAll(allJarPaths)
386389
}
387390
}
388391

@@ -438,7 +441,7 @@ task generateTypescriptDefinitions(type: JavaExec) {
438441
paramz.add("dts-generator.jar")
439442
paramz.add("-input")
440443

441-
for (String jarPath : project.jarFiles) {
444+
for (String jarPath : allJarLibraries) {
442445
// don't generate typings for runtime jars and classes
443446
if (shouldIncludeDirForTypings(jarPath, includeDirs)) {
444447
paramz.add(jarPath)
@@ -457,6 +460,8 @@ generateTypescriptDefinitions.onlyIf {
457460
project.hasProperty("generateTypings") && Boolean.parseBoolean(project.generateTypings)
458461
}
459462

463+
collectAllJars.finalizedBy(generateTypescriptDefinitions)
464+
460465
static def shouldIncludeDirForTypings(path, includeDirs) {
461466
for (String p : includeDirs) {
462467
if (path.indexOf(p) > -1) {
@@ -479,6 +484,7 @@ task copyTypings {
479484
}
480485

481486
copyTypings.onlyIf { generateTypescriptDefinitions.didWork }
487+
generateTypescriptDefinitions.finalizedBy(copyTypings)
482488

483489
task validateAppIdMatch {
484490
doLast {

0 commit comments

Comments
 (0)