Skip to content

Commit c5be5fb

Browse files
authored
Merge branch 'master' into vmutafov/merge-release-to-master
2 parents 35d0338 + b68158f commit c5be5fb

File tree

8 files changed

+27
-6
lines changed

8 files changed

+27
-6
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "tns-android",
33
"description": "NativeScript Runtime for Android",
4-
"version": "6.0.1",
4+
"version": "6.1.0",
55
"repository": {
66
"type": "git",
77
"url": "https://github.com/NativeScript/android-runtime.git"
@@ -11,7 +11,7 @@
1111
],
1212
"gradle": {
1313
"version": "5.1.1",
14-
"android": "3.4.1"
14+
"android": "3.4.2"
1515
},
1616
"android_ndk_version": "19c"
1717
}

test-app/build-tools/android-metadata-generator/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ buildscript {
1717
}
1818

1919
dependencies {
20-
classpath 'com.android.tools.build:gradle:3.4.1'
20+
classpath 'com.android.tools.build:gradle:3.4.2'
2121
}
2222
}
2323

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,12 @@ public void writeInternalServiceOnCreateMethod() {
389389
writer.write(INTERNAL_SERVICES_ONCREATE_METHOD_SIGNATURE);
390390
writer.write(OPENING_CURLY_BRACKET_LITERAL);
391391

392+
writer.write(SUPER_METHOD_CALL_PREFIX);
393+
writer.write(ON_CREATE_METHOD_NAME);
394+
writer.write(OPENING_ROUND_BRACKET_LITERAL);
395+
writer.write(CLOSING_ROUND_BRACKET_LITERAL);
396+
writer.write(END_OF_STATEMENT_LITERAL);
397+
392398
writeRuntimeInitializationForService();
393399

394400
writer.write(CLOSING_CURLY_BRACKET_LITERAL);

test-app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ buildscript {
77
jcenter()
88
}
99
dependencies {
10-
classpath 'com.android.tools.build:gradle:3.4.1'
10+
classpath 'com.android.tools.build:gradle:3.4.2'
1111
}
1212
}
1313

test-app/runtime/src/main/cpp/v8_inspector/src/inspector/utils/v8-inspector-common.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
//
44

55
#include <v8_inspector/src/inspector/utils/v8-inspector-common.h>
6+
#include <codecvt>
7+
#include <locale>
68
#include <ArgConverter.h>
79
#include <NativeScriptAssert.h>
810

@@ -39,6 +41,16 @@ protocol::DispatchResponse Common::protocolCommandNotSupportedDispatchResponse()
3941
return protocol::DispatchResponse::Error(s_notImplemented);
4042
}
4143

44+
std::vector<uint16_t> Common::toVector(const std::string &value) {
45+
std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> convert;
46+
std::u16string valueu16 = convert.from_bytes(value);
47+
48+
const uint16_t *begin = reinterpret_cast<uint16_t const *>(valueu16.data());
49+
const uint16_t *end = reinterpret_cast<uint16_t const *>(valueu16.data() + valueu16.size());
50+
std::vector<uint16_t> vector(begin, end);
51+
return vector;
52+
}
53+
4254
const String16 Common::s_notImplemented = "Protocol command not supported.";
4355
}
4456
}

test-app/runtime/src/main/cpp/v8_inspector/src/inspector/utils/v8-inspector-common.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ class Common {
1818

1919
static protocol::DispatchResponse protocolCommandNotSupportedDispatchResponse();
2020

21+
static std::vector<uint16_t> toVector(const std::string& value);
22+
2123
private:
2224
static const String16 s_notImplemented;
2325
};

test-app/runtime/src/main/cpp/v8_inspector/src/inspector/v8-log-agent-impl.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ void V8LogAgentImpl::EntryAdded(const std::string& text, std::string verbosityLe
7171
auto nano = std::chrono::time_point_cast<std::chrono::milliseconds>(std::chrono::system_clock::now());
7272
double timestamp = nano.time_since_epoch().count();
7373

74-
auto textString16 = String16(text.data());
74+
auto vector = utils::Common::toVector(text);
75+
auto textString16 = String16(vector.data(), vector.size());
7576

7677
auto logEntry = protocol::Log::LogEntry::create()
7778
.setSource(protocol::Log::LogEntry::SourceEnum::Javascript)

v8-versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
">=5.9.9 <6.1.0": "7.5.288.22",
2+
">=5.9.9 <6.2.0": "7.5.288.22",
33
">=5.3.9 <5.9.0": "7.4.288.25",
44
">=5.2.9 <5.4.0": "7.3.492.25",
55
">=5.1.9 <5.3.0": "7.1.302.32",

0 commit comments

Comments
 (0)