expose attributeRemoved and attributeModified on the __inspector object

Author: petekanev

runtime/src/main/jni/DOMDomainCallbackHandlers.cpp

@@ -100,12 +100,70 @@ void DOMDomainCallbackHandlers::ChildNodeRemovedCallback(const v8::FunctionCallb
 }
 
 void DOMDomainCallbackHandlers::AttributeModifiedCallback(const v8::FunctionCallbackInfo<v8::Value> &args) {
-    auto domAgentInstance = V8DOMAgentImpl::Instance;
+    try {
+        auto domAgentInstance = V8DOMAgentImpl::Instance;
 
-    if (!domAgentInstance) {
-        return;
+        if (!domAgentInstance) {
+            return;
+        }
+
+        auto isolate = args.GetIsolate();
+
+        v8::HandleScope scope(isolate);
+
+        if (args.Length() != 3 || !(args[0]->IsNumber() && args[1]->IsString() && args[2]->IsString())) {
+            throw NativeScriptException("Calling AttributeModified with invalid arguments. Required params: nodeId: number, name: string, value: string");
+        }
+
+        auto nodeId = args[0]->ToNumber(isolate);
+        auto attributeName = args[1]->ToString();
+        auto attributeValue = args[2]->ToString();
+
+         domAgentInstance->m_frontend.attributeModified(nodeId->Int32Value(),
+                                                        ArgConverter::ConvertToString(attributeName).c_str(),
+                                                        ArgConverter::ConvertToString(attributeValue).c_str());
+    } catch (NativeScriptException& e) {
+        e.ReThrowToV8();
+    } catch (std::exception e) {
+        std::stringstream ss;
+        ss << "Error: c exception: " << e.what() << std::endl;
+        NativeScriptException nsEx(ss.str());
+        nsEx.ReThrowToV8();
+    } catch (...) {
+        NativeScriptException nsEx(std::string("Error: c exception!"));
+        nsEx.ReThrowToV8();
     }
+}
+
+void DOMDomainCallbackHandlers::AttributeRemovedCallback(const v8::FunctionCallbackInfo<v8::Value> &args) {
+    try {
+        auto domAgentInstance = V8DOMAgentImpl::Instance;
+
+        if (!domAgentInstance) {
+            return;
+        }
+        auto isolate = args.GetIsolate();
+
+        v8::HandleScope scope(isolate);
+
+        if (args.Length() != 2 || !(args[0]->IsNumber() && args[1]->IsString())) {
+            throw NativeScriptException("Calling AttributeRemoved with invalid arguments. Required params: nodeId: number, name: string");
+        }
 
+        auto nodeId = args[0]->ToNumber(isolate);
+        auto attributeName = args[1]->ToString();
 
-//    domAgentInstance->m_frontend.attributeModified();
-}
+        domAgentInstance->m_frontend.attributeRemoved(nodeId->Int32Value(),
+                                                       ArgConverter::ConvertToString(attributeName).c_str());
+    } catch (NativeScriptException& e) {
+        e.ReThrowToV8();
+    } catch (std::exception e) {
+        std::stringstream ss;
+        ss << "Error: c exception: " << e.what() << std::endl;
+        NativeScriptException nsEx(ss.str());
+        nsEx.ReThrowToV8();
+    } catch (...) {
+        NativeScriptException nsEx(std::string("Error: c exception!"));
+        nsEx.ReThrowToV8();
+    }
+}

runtime/src/main/jni/DOMDomainCallbackHandlers.h

@@ -18,6 +18,7 @@ namespace tns {
         static void ChildNodeInsertedCallback(const v8::FunctionCallbackInfo<v8::Value>& args);
         static void ChildNodeRemovedCallback(const v8::FunctionCallbackInfo<v8::Value>& args);
         static void AttributeModifiedCallback(const v8::FunctionCallbackInfo<v8::Value>& args);
+        static void AttributeRemovedCallback(const v8::FunctionCallbackInfo<v8::Value>& args);
     };
 }
 

runtime/src/main/jni/JsV8InspectorClient.cpp

@@ -277,6 +277,7 @@ void JsV8InspectorClient::attachInspectorCallbacks(Isolate* isolate,
     inspectorJSObject->Set(ArgConverter::ConvertToV8String(isolate, "childNodeInserted"), FunctionTemplate::New(isolate, DOMDomainCallbackHandlers::ChildNodeInsertedCallback));
     inspectorJSObject->Set(ArgConverter::ConvertToV8String(isolate, "childNodeRemoved"), FunctionTemplate::New(isolate, DOMDomainCallbackHandlers::ChildNodeRemovedCallback));
     inspectorJSObject->Set(ArgConverter::ConvertToV8String(isolate, "attributeModified"), FunctionTemplate::New(isolate, DOMDomainCallbackHandlers::AttributeModifiedCallback));
+    inspectorJSObject->Set(ArgConverter::ConvertToV8String(isolate, "attributeRemoved"), FunctionTemplate::New(isolate, DOMDomainCallbackHandlers::AttributeRemovedCallback));
 
     globalObjectTemplate->Set(ArgConverter::ConvertToV8String(isolate, "__inspector"), inspectorJSObject);
 }