Merge pull request #92 from telerik/kddimitrov/fix-no-device-identifier-check

Fix simulator identifier not verified before startEmulator.

Author: rosen-vladimirov

lib/ios-sim.ts

@@ -59,7 +59,8 @@ Object.defineProperty(publicApi, "getInstalledApplications", {
 	"printDeviceLog",
 	"getDeviceLogProcess",
 	"startSimulator",
-	"getSimulatorName"].forEach(methodName => {
+	"getSimulatorName",
+	"getDevices"].forEach(methodName => {
 		Object.defineProperty(publicApi, methodName, {
 			get: () => {
 				return (...args: any[]) => {

lib/iphone-simulator-xcode-simctl.ts

@@ -164,6 +164,9 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I
 
 	public startSimulator(device?: IDevice): void {
 		device = device || this.getDeviceToRun();
+
+		this.verifyDevice(device);
+
 		if (!this.isDeviceBooted(device)) {
 			let bootedDevice = this.getBootedDevice();
 			if (bootedDevice && bootedDevice.id !== device.id) {
@@ -178,6 +181,14 @@ export class XCodeSimctlSimulator extends IPhoneSimulatorNameGetter implements I
 		}
 	}
 
+	private verifyDevice(device?: IDevice): void {
+		const availableDevices = this.getDevices();
+
+		if (!_.find(availableDevices, { id: device.id })) {
+			errors.fail(`No simulator image available for device identifier '${device.id}'.`);
+		}
+	}
+
 	private killSimulator(): void {
 		childProcess.execSync("pkill -9 -f Simulator");
 	}